From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-pm@vger.kernel.org
Subject: Re: Print PCI device in power management warning.
Date: Fri, 23 Dec 2011 20:44:07 +0000 [thread overview]
Message-ID: <20111223204407.54363939@pyx> (raw)
In-Reply-To: <20111223181626.GA18647@redhat.com>
On Fri, 23 Dec 2011 13:16:26 -0500
Dave Jones <davej@redhat.com> wrote:
> When the WARN_ON in pci_has_legacy_pm_support() triggers, we get
> users filing backtraces, but it's not obvious which driver is
> triggering the trace. This adds a printk before the BUG.
> This still isn't perfect (automated tools like abrt will still miss it)
> but we can at least ask the user to look through their dmesg when
> we get these traces reported.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
NAK
The old code did a WARN() the new code BUG() which in practice means in
many cases the user will get a crash and hang at boot and not even be
able to catch the trap.
At the very least your changelog should warn people it changes from
WARN_ON noise to system crash and burn.
Alan
prev parent reply other threads:[~2011-12-23 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 18:16 Print PCI device in power management warning Dave Jones
2011-12-23 20:26 ` Konrad Rzeszutek Wilk
2011-12-23 20:46 ` Dave Jones
2011-12-23 22:04 ` Randy Dunlap
2011-12-23 20:44 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111223204407.54363939@pyx \
--to=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.