From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] drivers/mfd/88pm860x-i2c.c: introduce missing kfree
Date: Mon, 26 Dec 2011 12:20:11 +0000 [thread overview]
Message-ID: <20111226122011.GG8722@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1112261318050.1873@localhost6.localdomain6>
On Mon, Dec 26, 2011 at 01:18:54PM +0100, Julia Lawall wrote:
> On Mon, 26 Dec 2011, Mark Brown wrote:
> >With this and probably a bunch of the other corrections in this series a
> >conversion to devm_kazlloc() would be a more complete fix as it prevents
> >people introducing similar missing cleanup paths in future. Not sure if
> >spatch can generate that automatically though...
> I saw a patch for that recently, and looked into it a little bit,
> but I wasn't sure what should be done. What are the criteria for
> using devm_kzalloc?
It's good for any allocation that lasts for the lifetime of the device -
most driver data allocated in probe() fits well, for example.
next prev parent reply other threads:[~2011-12-26 12:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 17:39 [PATCH 1/9] drivers/mfd/88pm860x-i2c.c: introduce missing kfree Julia Lawall
2011-12-23 17:39 ` Julia Lawall
2011-12-26 12:08 ` Mark Brown
2011-12-26 12:18 ` [PATCH 1/9] drivers/mfd/88pm860x-i2c.c: introduce missing Julia Lawall
2011-12-26 12:18 ` [PATCH 1/9] drivers/mfd/88pm860x-i2c.c: introduce missing kfree Julia Lawall
2011-12-26 12:20 ` Mark Brown [this message]
2011-12-26 13:44 ` devm_kfree Julia Lawall
2011-12-26 13:44 ` devm_kfree Julia Lawall
2011-12-26 14:23 ` devm_kfree Mark Brown
2011-12-26 16:17 ` devm_kfree Julia Lawall
2011-12-26 16:17 ` devm_kfree Julia Lawall
2011-12-26 16:19 ` devm_kfree Mark Brown
2011-12-27 2:48 ` devm_kfree Adam Jiang
2011-12-27 2:48 ` devm_kfree Adam Jiang
2011-12-27 6:10 ` devm_kfree Julia Lawall
2011-12-27 6:10 ` devm_kfree Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111226122011.GG8722@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.