From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Mon, 26 Dec 2011 14:23:55 +0000 Subject: Re: devm_kfree Message-Id: <20111226142354.GI8722@opensource.wolfsonmicro.com> List-Id: References: <1324661974-17281-1-git-send-email-julia@diku.dk> <20111226120855.GB17760@sirena.org.uk> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Julia Lawall , Samuel Ortiz , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Dec 26, 2011 at 02:44:58PM +0100, Julia Lawall wrote: > Is it reasonable to use devm_kfree in a probe function that fails or > a remove function that succeeds? If we need to do this I'd suggest that we should be fixing the manager to not need it rather than having drivers do this.