From: "Jörn Engel" <joern@logfs.org>
To: Roland Dreier <roland@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Steve Hodgson <steve@purestorage.com>
Subject: Re: [PATCH] btree: Export btree_get_prev() so modules can use btree_for_each
Date: Fri, 30 Dec 2011 10:36:38 +0100 [thread overview]
Message-ID: <20111230093638.GC26473@logfs.org> (raw)
In-Reply-To: <1325062439-1325-1-git-send-email-roland@kernel.org>
On Wed, 28 December 2011 00:53:59 -0800, Roland Dreier wrote:
>
> From: Steve Hodgson <steve@purestorage.com>
>
> The btree_for_each API is implemented with macros that internally call
> btree_get_prev(), so if btree_get_prev() isn't exported then modules
> fail to link if they try to use one of the btree_for_each macros. Since
> the rest of the btree API is exported, we should keep things orthogonal
> and make this work too.
>
> Cc: Joern Engel <joern@logfs.org>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
Acked-by: Joern Engel <joern@logfs.org>
> ---
> lib/btree.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/lib/btree.c b/lib/btree.c
> index 2a34392..e5ec1e9 100644
> --- a/lib/btree.c
> +++ b/lib/btree.c
> @@ -357,6 +357,7 @@ miss:
> }
> return NULL;
> }
> +EXPORT_SYMBOL_GPL(btree_get_prev);
>
> static int getpos(struct btree_geo *geo, unsigned long *node,
> unsigned long *key)
> --
> 1.7.5.4
>
Jörn
--
"Error protection by error detection and correction."
-- from a university class
next prev parent reply other threads:[~2011-12-30 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 8:53 [PATCH] btree: Export btree_get_prev() so modules can use btree_for_each Roland Dreier
2011-12-30 9:36 ` Jörn Engel [this message]
[not found] ` <CADHUQJ4NHSGs-=g-rfzoAWRLi8SmNPtfeeC4XPuAa2bO91oRug@mail.gmail.com>
2012-01-01 7:16 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111230093638.GC26473@logfs.org \
--to=joern@logfs.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@kernel.org \
--cc=steve@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.