Re: [lm-sensors] [PATCH 2/4] drivers/hwmon/lm75.c: added error

[Guenter Roeck <guenter.roeck@ericsson.com>]

Hi Frans,

On Mon, Jan 02, 2012 at 06:03:21AM -0500, Frans Meulenbroeks wrote:
> added error handling so if lm75_update_device fails
> an error is returned when reading the value through sysfs
> This is closely modeled after the way this is handled in ltc4261
> 
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> ---
> patch is against the hwmon staging tree
> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
> as retrieved on jan 2, 2012
> 
>  drivers/hwmon/lm75.c |   20 +++++++++++++++-----
>  1 files changed, 15 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 1888dd0..21abae2 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -93,6 +93,10 @@ static ssize_t show_temp(struct device *dev, struct device_attribute *da,
>  {
>  	struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
>  	struct lm75_data *data = lm75_update_device(dev);
> +
> +	if (IS_ERR(data))
> +		return PTR_ERR(data);
> +
>  	return sprintf(buf, "%d\n",
>  		       LM75_TEMP_FROM_REG(data->temp[attr->index]));
>  }
> @@ -402,6 +406,7 @@ static struct lm75_data *lm75_update_device(struct device *dev)
>  {
>  	struct i2c_client *client = to_i2c_client(dev);
>  	struct lm75_data *data = i2c_get_clientdata(client);
> +	struct lm75_data *ret = data;
>  
>  	mutex_lock(&data->update_lock);
>  
> @@ -414,9 +419,14 @@ static struct lm75_data *lm75_update_device(struct device *dev)
>  			int status;
>  
>  			status = lm75_read_value(client, LM75_REG_TEMP[i]);
> -			if (status < 0)
> -				dev_dbg(&client->dev, "reg %d, err %d\n",
> -						LM75_REG_TEMP[i], status);
> +			if (unlikely(status < 0)) {
> +				dev_dbg(dev,
> +					"LM75: Failed to read value: reg %d, error %d\n",
> +					LM75_REG_TEMP[i], status);
> +				ret = ERR_PTR(status);
> +				data->valid = 0;
> +				goto abort;
> +			}
>  			else
>  				data->temp[i] = status;

Since the if now aborts, you don't need the else anymore. Also, if you kept the else
(which you don't really want to), you should put braces around the else branch
if there are braces around the if branch (CodingStyle, chapter 3).

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors