From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 3/4] drivers/hwmon/lm80.c: added error
Date: Mon, 02 Jan 2012 16:54:28 +0000 [thread overview]
Message-ID: <20120102165428.GE17788@ericsson.com> (raw)
In-Reply-To: <1325502203-10525-3-git-send-email-fransmeulenbroeks@gmail.com>
On Mon, Jan 02, 2012 at 06:03:22AM -0500, Frans Meulenbroeks wrote:
> added error handling so if lm80_update_device fails
> an error is returned when reading the value through sysfs
> This is closely modeled after the way this is handled in ltc4261
>
> Note: if update gets an error, this error is returned for all
> registers and no further reads are done.
> If a register is not accessible most likely the whole device
> is broken or disconnected and it is definitely interesting to know.
>
> Note2: I added a macro to read and handle errors. This was felt to
> be the simplest. If someone feels it should be done using a
> subroutine, be my guest.
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Another note: checkpatch.pl reports 2 errors and 10 warnings on this patch.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-01-02 16:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 11:03 [lm-sensors] [PATCH 3/4] drivers/hwmon/lm80.c: added error handling Frans Meulenbroeks
2012-01-02 11:23 ` [lm-sensors] [PATCH 3/4] drivers/hwmon/lm80.c: added error Frans Meulenbroeks
2012-01-02 16:48 ` Guenter Roeck
2012-01-02 16:54 ` Guenter Roeck [this message]
2012-01-03 10:32 ` Frans Meulenbroeks
2012-01-03 17:26 ` Guenter Roeck
2012-01-03 22:17 ` Frans Meulenbroeks
2012-01-03 23:27 ` Guenter Roeck
2012-01-05 14:21 ` Jean Delvare
2012-01-05 14:52 ` Frans Meulenbroeks
2012-01-26 19:03 ` [lm-sensors] [PATCH 3/4] drivers/hwmon/lm80.c: added error handling Jean Delvare
2012-01-26 21:04 ` Frans Meulenbroeks
2012-01-27 13:22 ` Frans Meulenbroeks
2012-01-28 18:52 ` Jean Delvare
2012-01-28 19:39 ` Frans Meulenbroeks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102165428.GE17788@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.