From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>
Subject: Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)
Date: Tue, 3 Jan 2012 15:58:13 +0300 [thread overview]
Message-ID: <20120103125813.GB3626@mwanda> (raw)
In-Reply-To: <87ehw6sesk.fsf@rustcorp.com.au>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Thu, Dec 15, 2011 at 01:48:51PM +1030, Rusty Russell wrote:
> diff --git a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
> --- a/drivers/block/paride/pcd.c
> +++ b/drivers/block/paride/pcd.c
> @@ -105,13 +105,14 @@
> #define PCD_NAME "pcd"
> #define PCD_UNITS 4
>
> +#include <linux/types.h>
> /* Here are things one can override from the insmod command.
> Most are autoprobed by paride unless set here. Verbose is off
> by default.
>
> */
>
> -static int verbose = 0;
> +static bool verbose = 0;
This should be int. Verbose can be set to 2 for extra verbosity.
Btw, these patches that touch a ton of drivers are the wrong idea.
If you ack any part of it, then get_maintainer.pl CCs you on every
single kernel patch until eventually you get old and die.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-03 12:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 3:18 [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc) Rusty Russell
2012-01-03 12:44 ` Dan Carpenter
2012-01-04 2:27 ` Rusty Russell
2012-01-03 12:58 ` Dan Carpenter [this message]
2012-01-03 13:17 ` [patch] TPM: handle errors from probe_itpm() Dan Carpenter
2012-01-03 13:17 ` Dan Carpenter
2012-01-04 2:29 ` [PATCH] intelfbdrv.c: bailearly is an int module_param Rusty Russell
2012-01-04 2:41 ` Rusty Russell
2012-01-04 2:30 ` [PATCH] paride/pcd: fix bool verbose module parameter Rusty Russell
2012-01-04 7:12 ` [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc) Tomi Valkeinen
2012-01-05 0:03 ` Rusty Russell
2012-01-06 12:31 ` Geert Uytterhoeven
2012-01-09 6:26 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103125813.GB3626@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.