From: Mike Frysinger <vapier@gentoo.org>
To: ltp-list@lists.sourceforge.net
Cc: Markos Chandras <Markos.Chandras@imgtec.com>
Subject: Re: [LTP] [PATCH 16/21] kernel/vma: Add missing return statement for non-void functions
Date: Tue, 3 Jan 2012 15:32:04 -0500 [thread overview]
Message-ID: <201201031532.04811.vapier@gentoo.org> (raw)
In-Reply-To: <4F0300EC.7040201@imgtec.com>
[-- Attachment #1.1: Type: Text/Plain, Size: 374 bytes --]
On Tuesday 03 January 2012 08:21:48 Markos Chandras wrote:
> Hi, please review the attached patch
two of these hunks are fallout of your tst_brkm() no attribute change. those
don't actually return, so there shouldn't be a need to add explicit returns.
the 3rd hunk (adding a return after tst_exit) is wrong -- that is marked
noreturn and isn't changing.
-mike
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 355 bytes --]
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create
new or port existing apps to sell to consumers worldwide. Explore the
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2012-01-03 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 13:21 [LTP] [PATCH 16/21] kernel/vma: Add missing return statement for non-void functions Markos Chandras
2012-01-03 20:32 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201031532.04811.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=Markos.Chandras@imgtec.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.