From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Date: Tue, 03 Jan 2012 18:42:26 +0000 Subject: Re: [PATCH 4/9] drivers/xen/gntalloc.c: introduce missing kfree Message-Id: <20120103184226.GA27508@phenom.dumpdata.com> List-Id: References: <1324661974-17281-4-git-send-email-julia@diku.dk> In-Reply-To: <1324661974-17281-4-git-send-email-julia@diku.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Jeremy Fitzhardinge , xen-devel@lists.xensource.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org On Fri, Dec 23, 2011 at 06:39:29PM +0100, Julia Lawall wrote: > Error handling code following a kmalloc should free the allocated data. > Out_unlock is used on both success and failure, so free vm_priv before > jumping to that label. Applied. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 4/9] drivers/xen/gntalloc.c: introduce missing kfree Date: Tue, 3 Jan 2012 13:42:26 -0500 Message-ID: <20120103184226.GA27508@phenom.dumpdata.com> References: <1324661974-17281-4-git-send-email-julia@diku.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1324661974-17281-4-git-send-email-julia@diku.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Julia Lawall Cc: Jeremy Fitzhardinge , xen-devel@lists.xensource.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Fri, Dec 23, 2011 at 06:39:29PM +0100, Julia Lawall wrote: > Error handling code following a kmalloc should free the allocated data. > Out_unlock is used on both success and failure, so free vm_priv before > jumping to that label. Applied. Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754664Ab2ACSop (ORCPT ); Tue, 3 Jan 2012 13:44:45 -0500 Received: from rcsinet15.oracle.com ([148.87.113.117]:58528 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754537Ab2ACSom (ORCPT ); Tue, 3 Jan 2012 13:44:42 -0500 Date: Tue, 3 Jan 2012 13:42:26 -0500 From: Konrad Rzeszutek Wilk To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Jeremy Fitzhardinge , xen-devel@lists.xensource.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/9] drivers/xen/gntalloc.c: introduce missing kfree Message-ID: <20120103184226.GA27508@phenom.dumpdata.com> References: <1324661974-17281-4-git-send-email-julia@diku.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1324661974-17281-4-git-send-email-julia@diku.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4F034C74.0142,ss=1,re=0.000,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2011 at 06:39:29PM +0100, Julia Lawall wrote: > Error handling code following a kmalloc should free the allocated data. > Out_unlock is used on both success and failure, so free vm_priv before > jumping to that label. Applied. Thanks!