From: Dan Carpenter <dan.carpenter@oracle.com>
To: mchehab@redhat.com
Cc: linux-media@vger.kernel.org
Subject: re: [media] cx23885-dvb: Remove a dirty hack that would require DVBv3
Date: Wed, 4 Jan 2012 09:45:21 +0300 [thread overview]
Message-ID: <20120104064521.GA29273@elgon.mountain> (raw)
Hello Mauro Carvalho Chehab,
This is a semi-automatic email about new static checker warnings.
The patch a7d44baaed0a: "[media] cx23885-dvb: Remove a dirty hack
that would require DVBv3" from Dec 26, 2011, leads to the following
Smatch complaint:
drivers/media/video/cx23885/cx23885-dvb.c +135 cx23885_dvb_gate_ctrl()
error: we previously assumed 'fe' could be null (see line 128)
drivers/media/video/cx23885/cx23885-dvb.c
127
128 if (fe && fe->dvb.frontend && fe->dvb.frontend->ops.i2c_gate_ctrl)
^^
Old condition.
129 fe->dvb.frontend->ops.i2c_gate_ctrl(fe->dvb.frontend, open);
130
131 /*
132 * FIXME: Improve this path to avoid calling the
133 * cx23885_dvb_set_frontend() every time it passes here.
134 */
135 cx23885_dvb_set_frontend(fe->dvb.frontend);
^^^^
New dereference.
136 }
137
regards,
dan carpenter
next reply other threads:[~2012-01-04 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 6:45 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-05-15 8:48 [media] cx23885-dvb: Remove a dirty hack that would require DVBv3 Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104064521.GA29273@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.