All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dave Jones <davej@redhat.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Ingo Molnar <mingo@elte.hu>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	x86@kernel.org
Subject: Re: Add Dell Studio 1557 to pci=nocrs blacklist
Date: Wed, 4 Jan 2012 09:08:41 -0800	[thread overview]
Message-ID: <20120104090841.5007db44@jbarnes-desktop> (raw)
In-Reply-To: <20120104163311.GB31667@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

On Wed, 4 Jan 2012 11:33:12 -0500
Dave Jones <davej@redhat.com> wrote:

> The Dell Studio 1557 also doesn't suspend correctly when CRS is enabled.
> Details at https://bugzilla.redhat.com/show_bug.cgi?id=769657
> 
> Reported-by: Gregory S. Hoerner <ghoerner@transcendingthought.com>
> Signed-off-by: Dave Jones <davej@redhat.com>
>  
> --- linux-3.1.noarch/arch/x86/pci/acpi.c~	2012-01-04 11:19:36.783664477 -0500
> +++ linux-3.1.noarch/arch/x86/pci/acpi.c	2012-01-04 11:23:42.403666272 -0500
> @@ -75,6 +75,16 @@ static const struct dmi_system_id pci_us
>  	/* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
>  	{
>  		.callback = set_nouse_crs,
> +		.ident = "Dell Studio 1557",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1557");
> +			DMI_MATCH(DMI_BIOS_VERSION, "A09"),
> +		},
> +	},
> +	/* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
> +	{
> +		.callback = set_nouse_crs,
>  		.ident = "Thinkpad SL510",
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> 

Looks like this depends on a Thinkpad patch you haven't sent yet; did
you mean to?

I've fixed it up by hand and applied both the 1536 and 1557 patches to
my for-linus branch.  I'll see if Linus wants to take it before he
releases (doubtful, but it would be nice if these machines just worked
with the new kernel).

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-01-04 17:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-30 19:37 Dell Studio 1536 needs pci=nocrs to boot Dave Jones
2012-01-01 14:53 ` Ingo Molnar
2012-01-03 17:30   ` Jesse Barnes
2012-01-03 17:55     ` Bjorn Helgaas
2012-01-03 18:00       ` Dave Jones
2012-01-06 17:32         ` Bjorn Helgaas
2012-01-06 17:57           ` Dave Jones
2012-01-06 20:10             ` Jesse Barnes
2012-01-04 16:33       ` Add Dell Studio 1557 to pci=nocrs blacklist Dave Jones
2012-01-04 17:08         ` Jesse Barnes [this message]
2012-01-04 18:37         ` Ingo Molnar
2012-01-11 16:07           ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120104090841.5007db44@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=bhelgaas@google.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.