From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: [PATCH 2/3] cgroup: replace tasklist_lock with rcu_read_lock Date: Wed, 4 Jan 2012 11:38:18 +0100 Message-ID: <20120104103810.GA1143@somewhere> References: <1325654312-32477-1-git-send-email-msb@chromium.org> <1325654312-32477-2-git-send-email-msb@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=pRljJjkbPjr7v2/RDX+RG3U5yHFHeiHzU7TDAk4EmtA=; b=tRJADzjHKUPLmR5Yq9Pi03rH9/0Ir++sfiCQ8GAbxXNsSwmZDxe3iyUndgBpMjChYn dl6vrrBKndKza2CCV2DgxR1P5eStXhsqhr3d9lGxb9+dGsKiNVR1zC+qr0/y1CIpzpB+ ZX5UikslDi63UdXnNXgheHGbdK+YPi2krf5AM= Content-Disposition: inline In-Reply-To: <1325654312-32477-2-git-send-email-msb-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Mandeep Singh Baines Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Oleg Nesterov , Tejun Heo , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Morton , Paul Menage On Tue, Jan 03, 2012 at 09:18:31PM -0800, Mandeep Singh Baines wrote: > We can replace the tasklist_lock in cgroup_attach_proc with an > rcu_read_lock. > > Changes in V4: > * https://lkml.org/lkml/2011/12/23/284 (Frederic Weisbecker) > * Minimize size of rcu_read_lock critical section > * Add comment > * https://lkml.org/lkml/2011/12/26/136 (Li Zefan) > * Split into two patches > Changes in V3: > * https://lkml.org/lkml/2011/12/22/419 (Frederic Weisbecker) > * Add an rcu_read_lock to protect against exit > Changes in V2: > * https://lkml.org/lkml/2011/12/22/86 (Tejun Heo) > * Use a goto instead of returning -EAGAIN > > Suggested-by: Frederic Weisbecker > Signed-off-by: Mandeep Singh Baines > Cc: Tejun Heo > Cc: Li Zefan > Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: KAMEZAWA Hiroyuki > Cc: Oleg Nesterov > Cc: Andrew Morton > Cc: Paul Menage Acked-by: Frederic Weisbecker Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755338Ab2ADKi1 (ORCPT ); Wed, 4 Jan 2012 05:38:27 -0500 Received: from mail-vx0-f174.google.com ([209.85.220.174]:35746 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755292Ab2ADKiY (ORCPT ); Wed, 4 Jan 2012 05:38:24 -0500 Date: Wed, 4 Jan 2012 11:38:18 +0100 From: Frederic Weisbecker To: Mandeep Singh Baines Cc: Tejun Heo , Li Zefan , linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, KAMEZAWA Hiroyuki , Oleg Nesterov , Andrew Morton , Paul Menage Subject: Re: [PATCH 2/3] cgroup: replace tasklist_lock with rcu_read_lock Message-ID: <20120104103810.GA1143@somewhere> References: <1325654312-32477-1-git-send-email-msb@chromium.org> <1325654312-32477-2-git-send-email-msb@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1325654312-32477-2-git-send-email-msb@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2012 at 09:18:31PM -0800, Mandeep Singh Baines wrote: > We can replace the tasklist_lock in cgroup_attach_proc with an > rcu_read_lock. > > Changes in V4: > * https://lkml.org/lkml/2011/12/23/284 (Frederic Weisbecker) > * Minimize size of rcu_read_lock critical section > * Add comment > * https://lkml.org/lkml/2011/12/26/136 (Li Zefan) > * Split into two patches > Changes in V3: > * https://lkml.org/lkml/2011/12/22/419 (Frederic Weisbecker) > * Add an rcu_read_lock to protect against exit > Changes in V2: > * https://lkml.org/lkml/2011/12/22/86 (Tejun Heo) > * Use a goto instead of returning -EAGAIN > > Suggested-by: Frederic Weisbecker > Signed-off-by: Mandeep Singh Baines > Cc: Tejun Heo > Cc: Li Zefan > Cc: containers@lists.linux-foundation.org > Cc: cgroups@vger.kernel.org > Cc: KAMEZAWA Hiroyuki > Cc: Oleg Nesterov > Cc: Andrew Morton > Cc: Paul Menage Acked-by: Frederic Weisbecker Thanks!