From: "Eric Bénard" <eric@eukrea.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v4 4/5] timeout: add poller_call
Date: Wed, 4 Jan 2012 14:32:50 +0100 [thread overview]
Message-ID: <20120104143250.55a91f0d@eb-e6520> (raw)
In-Reply-To: <20120104114426.GA1810@game.jcrosoft.org>
Hi Jean-Christophe,
Le Wed, 4 Jan 2012 12:44:26 +0100,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> On 12:10 Wed 04 Jan , Eric Bénard wrote:
> > Hi Jean-Christophe,
> >
> > Le Wed, 4 Jan 2012 11:47:41 +0100,
> > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> a écrit :
> >
> > > On 10:36 Wed 04 Jan , Eric Bénard wrote:
> > > > without this, usb gadget can't enumerate during boot once the
> > > > timeout command is launched (thus preventing usbserial console
> > > > access to take control of the board before autoboot)
> > > >
> > > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > >
> > > I send a patch to put it in the is_timeout c code
> > >
> > I just saw it.
> >
> > > I think it's better
> > Maybe, I don't understand whyu you need to add if (time_offset_ns >=
> > 100 * USECOND) which was not here before.
> I'm working to add bitbanging i2c so I do not want the small delay to be
> impacted by the pull
>
then I suggest you first add the poll change without this test, and
then add this test once you add bitbanging i2c. That will make the
change more understandable.
Eric
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-01-04 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 9:36 [PATCH v4 1/5] fsl_udc: update and fix Eric Bénard
2012-01-04 9:36 ` [PATCH v4 2/5] dfu: fill bwPollTimeout and better handle detach Eric Bénard
2012-01-04 9:36 ` [PATCH v4 3/5] serial gadget: enable/disable on request Eric Bénard
2012-01-04 9:36 ` [PATCH v4 4/5] timeout: add poller_call Eric Bénard
2012-01-04 10:47 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-04 11:10 ` Eric Bénard
2012-01-04 11:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-04 13:32 ` Eric Bénard [this message]
2012-01-04 15:31 ` Eric Bénard
2012-01-04 9:36 ` [PATCH v4 5/5] eukrea_cpuimx35: fix compilation when CONFIG_USB_GADGET is enabled Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104143250.55a91f0d@eb-e6520 \
--to=eric@eukrea.com \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.