From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiUwp-0002rU-UN for qemu-devel@nongnu.org; Wed, 04 Jan 2012 12:48:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RiUwo-0003SG-V2 for qemu-devel@nongnu.org; Wed, 04 Jan 2012 12:48:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RiUwo-0003SC-N9 for qemu-devel@nongnu.org; Wed, 04 Jan 2012 12:48:22 -0500 Date: Wed, 4 Jan 2012 15:47:24 -0200 From: Marcelo Tosatti Message-ID: <20120104174724.GA21596@amt.cnet> References: <20120104140854.631720304@redhat.com> <20120104140945.618799948@redhat.com> <4F0477FE.3000801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F0477FE.3000801@redhat.com> Subject: Re: [Qemu-devel] [patch 3/4] block stream: add support for partial streaming List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org On Wed, Jan 04, 2012 at 09:02:06AM -0700, Eric Blake wrote: > On 01/04/2012 07:08 AM, Marcelo Tosatti wrote: > > Add support for streaming data from an intermediate section of the > > image chain (see patch and documentation for details). > > > > Signed-off-by: Marcelo Tosatti > > > > Index: stefanha/block.c > > =================================================================== > > --- stefanha.orig/block.c > > +++ stefanha/block.c > > @@ -2229,6 +2229,70 @@ int bdrv_is_allocated(BlockDriverState * > > return data.ret; > > } > > > > +/* > > + * Given an image chain: [BASE] -> [INTER1] -> [INTER2] -> [TOP] > > + * > > + * Return true if the given sector is allocated in top or base. > > + * Return false if the given sector is allocated in intermediate images. > > + * > > + * 'pnum' is set to the number of sectors (including and immediately following > > + * the specified sector) that are known to be in the same > > + * allocated/unallocated state. > > Not a problem with this patch, per say, so much as a question about the > next steps: > > How hard would it be to go one step further, and provide a monitor > command where qemu could dump the state of BASE, INTER1, or INTER2 > without removing it from the image chain? Libvirt would really like to > be able to have a command where the user can request to inspect to see > the contents of (a portion of) the disk at the time the snapshot was > created, all while qemu continues to run and the TOP file continues to > be adding deltas to that portion of the disk. What exactly do you mean "dump the state of"? You want access to the contents of INTER2, INTER1, BASE, via libguestfs? > For that matter, I'm still missing out on the ability to extract the > contents of a qcow2 internal snapshot from an image that is in use by > qemu - we have the ability to delete internal snapshots but not to probe > their contents. Same question (although i am not familiar with internal snapshots).