All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Cc: Bdale Garbee <bdale-wvU4uTqWWAI@public.gmane.org>,
	Sarah Sharp
	<sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	Oliver Neukum <oliver-Q6YOFhsQ4GZ7tPAFqOLdPg@public.gmane.org>,
	keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: USB disconnect -> kernel panic
Date: Wed, 4 Jan 2012 16:11:22 -0800	[thread overview]
Message-ID: <20120105001122.GA9974@kroah.com> (raw)
In-Reply-To: <20120104232659.05da01ee-38n7/U1jhRXW96NNrWNlrekiAK3p4hvP@public.gmane.org>

On Wed, Jan 04, 2012 at 11:26:59PM +0000, Alan Cox wrote:
> > Ok, can you try the patch below and let me know if it solves the problem
> > or not?
> 
> If it does the right fix is to stop clearing tty->driver_data. If
> tty->driver_data can go NULL outside of the final release then its
> probably an exploitable hole.

So in acm_tty_close() we shouldn't set driver_data to NULL after we
unregister the device?

Ah, that should happen in tty_operations->cleanup()?  It seems that
cdc_acm.c doesn't have that function, which is causing this problem now,
right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-01-05  0:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87mxahk3d1.fsf@gag.com>
     [not found] ` <20120102182255.GC8562@xanatos>
2012-01-03 23:58   ` USB disconnect -> kernel panic Greg KH
     [not found]     ` <20120103235847.GF21311-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-01-04  3:09       ` Bdale Garbee
     [not found]         ` <87fwfwmaeo.fsf-wvU4uTqWWAI@public.gmane.org>
2012-01-04 23:01           ` Greg KH
2012-01-04 23:26             ` Alan Cox
     [not found]               ` <20120104232659.05da01ee-38n7/U1jhRXW96NNrWNlrekiAK3p4hvP@public.gmane.org>
2012-01-05  0:11                 ` Greg KH [this message]
2012-01-05  5:36             ` Bdale Garbee
     [not found]               ` <87mxa2ww0f.fsf-wvU4uTqWWAI@public.gmane.org>
2012-01-05 20:04                 ` Greg KH
2012-01-04  9:01       ` Oliver Neukum
2012-01-04 17:26         ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120105001122.GA9974@kroah.com \
    --to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=bdale-wvU4uTqWWAI@public.gmane.org \
    --cc=keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=oliver-Q6YOFhsQ4GZ7tPAFqOLdPg@public.gmane.org \
    --cc=sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.