From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] loadb: only try to change the baudrate if the driver has this feature
Date: Thu, 5 Jan 2012 09:28:30 +0100 [thread overview]
Message-ID: <20120105082830.GX5446@pengutronix.de> (raw)
In-Reply-To: <20120104180423.5d13b88c@eb-e6520>
On Wed, Jan 04, 2012 at 06:04:23PM +0100, Eric Bénard wrote:
> Hi Sascha,
>
> Le Wed, 4 Jan 2012 17:37:56 +0100,
> Sascha Hauer <s.hauer@pengutronix.de> a écrit :
>
> > On Wed, Jan 04, 2012 at 04:01:16PM +0100, Eric Bénard wrote:
> > > this allows loadb to work over usbserial gadget
> >
> > I like the original approach better. The baudrate setting has no meaning
> > in hardware for the usb serial gadget. This means that we can happily
> > support every baudrate requested by adding a fake setbrg function.
> >
> > If we had some global console_setbrg function I would agree
> > Jean-Christophe, this function should return cdev->setbrg or
> > -ENOSYS if the driver does not have a setbrg function. Still the
> > usb gadget serial driver should have a fake setbrg function for
> > the reason explained above.
> >
> > This command could be improved by doing all this baudrate stuff only
> > when the -b option is given. This way we default to the current
> > baudrate (which seems sane in the cases I can think of)
> >
> OK so in conclusion, what do you prefer :
> - applying " u_serial: add setbrg to be able to use loadb & co"
> - a fix for loadb to only handle baudrate change if -b option is given
> - or maybe both options ? ;-)
Yes, both. The -b option patch was just something I saw when looking at
your patch.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-01-05 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 10:35 [PATCH] u_serial: add setbrg to be able to use loadb & co Eric Bénard
2012-01-04 11:45 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-04 15:01 ` [PATCH] loadb: only try to change the baudrate if the driver has this feature Eric Bénard
2012-01-04 16:37 ` Sascha Hauer
2012-01-04 17:04 ` Eric Bénard
2012-01-05 8:28 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105082830.GX5446@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.