From mboxrd@z Thu Jan 1 00:00:00 1970 From: Isaku Yamahata Subject: Re: =?iso-2022-jp?b?GyRCMnMbKEI/PzogIFtQQVRDSCAyLzJdIHVt?= =?iso-2022-jp?b?ZW06IGNoYXJkZXZpY2UgZm9yIGt2bSBwb3N0Y29weQ==?= Date: Thu, 5 Jan 2012 19:48:06 +0900 Message-ID: <20120105104806.GD6819@valinux.co.jp> References: <055fb826d9f0d88910f71b1afed0c06e4bfb8a76.1325055066.git.yamahata@valinux.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "t.hirofuchi" , qemu-devel , kvm , "satoshi.itoh" To: thfbjyddx Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Thu, Jan 05, 2012 at 12:08:50PM +0800, thfbjyddx wrote: > hi, > I've tried to use this patch, Oh great! Can we share your results? > but it doesn't work for compiling error on > > page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address);//vmf-> > virtual_address? > > I guess it's for the wrong kernel version? > can you give me some detail about this or any clue? > 3x Thank you for report. The following should fix. It depends on kernel configuration. My config didn't catch it. diff --git a/drivers/char/umem.c b/drivers/char/umem.c index 4d031b5..853f1ce 100644 --- a/drivers/char/umem.c +++ b/drivers/char/umem.c @@ -129,7 +129,7 @@ static int umem_minor_fault(struct umem *umem, * vmf->page = fake_vmf->page; */ - page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address); + page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->virtual_address); if (!page) return VM_FAULT_OOM; if (mem_cgroup_cache_charge(page, vma->vm_mm, GFP_KERNEL)) { -- yamahata From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rikro-0002GS-FK for qemu-devel@nongnu.org; Thu, 05 Jan 2012 05:48:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rikrk-00051a-Ji for qemu-devel@nongnu.org; Thu, 05 Jan 2012 05:48:16 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]:33814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rikrk-00051M-5J for qemu-devel@nongnu.org; Thu, 05 Jan 2012 05:48:12 -0500 Date: Thu, 5 Jan 2012 19:48:06 +0900 From: Isaku Yamahata Message-ID: <20120105104806.GD6819@valinux.co.jp> References: <055fb826d9f0d88910f71b1afed0c06e4bfb8a76.1325055066.git.yamahata@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] =?iso-2022-jp?b?GyRCMnMbKEI/PzogIFtQQVRDSCAyLzJdIHVt?= =?iso-2022-jp?b?ZW06IGNoYXJkZXZpY2UgZm9yIGt2bSBwb3N0Y29weQ==?= List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: thfbjyddx Cc: "t.hirofuchi" , qemu-devel , kvm , "satoshi.itoh" On Thu, Jan 05, 2012 at 12:08:50PM +0800, thfbjyddx wrote: > hi, > I've tried to use this patch, Oh great! Can we share your results? > but it doesn't work for compiling error on > > page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address);//vmf-> > virtual_address? > > I guess it's for the wrong kernel version? > can you give me some detail about this or any clue? > 3x Thank you for report. The following should fix. It depends on kernel configuration. My config didn't catch it. diff --git a/drivers/char/umem.c b/drivers/char/umem.c index 4d031b5..853f1ce 100644 --- a/drivers/char/umem.c +++ b/drivers/char/umem.c @@ -129,7 +129,7 @@ static int umem_minor_fault(struct umem *umem, * vmf->page = fake_vmf->page; */ - page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->address); + page = alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, vmf->virtual_address); if (!page) return VM_FAULT_OOM; if (mem_cgroup_cache_charge(page, vma->vm_mm, GFP_KERNEL)) { -- yamahata