From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: paper over missed irq issues with force wake vodoo Date: Thu, 5 Jan 2012 12:13:58 +0100 Message-ID: <20120105111358.GA3831@phenom.ffwll.local> References: <1325702445-2231-1-git-send-email-daniel.vetter@ffwll.ch> <86d3aylw83.fsf@sumi.keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 87579A08FC for ; Thu, 5 Jan 2012 03:12:03 -0800 (PST) Received: by wgbds11 with SMTP id ds11so312217wgb.12 for ; Thu, 05 Jan 2012 03:12:02 -0800 (PST) Content-Disposition: inline In-Reply-To: <86d3aylw83.fsf@sumi.keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: Daniel Vetter , intel-gfx , Eugeni Dodonov , stable@kernel.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 04, 2012 at 06:27:40PM -0800, Keith Packard wrote: > On Wed, 4 Jan 2012 19:40:45 +0100, Daniel Vetter wrote: > > > Two things seem to do the trick on my ivb machine here: > > - prevent the gt from powering down while waiting for seqno > > notification interrupts by grabbing the force_wake in get_irq (and > > dropping it in put_irq again). > > - ordering writes from the ring's CS by reading a CS register, ACTHD > > seems to work. > > If this works reliably, you'll deserve a medal... I've removed the HWSTAM workaround on my branch and both my ivb and snb seem to still work. So I'm still hopeful that this actually works ;-) Ben promised to beat on it with his machines, too, but I fear Eric is way too busy with the finishing touches for the OGL 3.0 frenzy atm. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48