From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 1/2] ext4fs ls load support
Date: Thu, 05 Jan 2012 16:32:01 +0100 [thread overview]
Message-ID: <20120105153201.C48E91FD3DA@gemini.denx.de> (raw)
In-Reply-To: <1325038933-10587-1-git-send-email-uma.shankar@samsung.com>
Dear uma.shankar at samsung.com,
In message <1325038933-10587-1-git-send-email-uma.shankar@samsung.com> you wrote:
> From: Uma Shankar <uma.shankar@samsung.com>
>
> Signed-off-by: Uma Shankar <uma.shankar@samsung.com>
> Signed-off-by: Manjunatha C Achar <a.manjunatha@samsung.com>
> Signed-off-by: Iqbal Shareef <iqbal.ams@samsung.com>
> Signed-off-by: Hakgoo Lee <goodguy.lee@samsung.com>
> ---
> Changes for v2:
> - Code cleanup, changed comment style
> - camel case removed, resolved code alignment issues
> - memory allocation logic changed, removed busybox logic
> - Modified ext4 load to remove grub dependency (GPLv3)
>
> Changes for v1:
> - Removed checkpatch warnings and errors
> - Moved common API's of ext2 and ext4 to one generic header file
>
> Makefile | 2 +-
> common/Makefile | 1 +
> common/cmd_ext2.c | 1 +
> common/cmd_ext4.c | 249 ++++++++++++++++++++++
> fs/Makefile | 1 +
> fs/ext2/dev.c | 1 +
> fs/ext2/ext2fs.c | 340 +++---------------------------
> fs/ext4/Makefile | 51 +++++
> fs/ext4/ext4_common.c | 565 +++++++++++++++++++++++++++++++++++++++++++++++++
> fs/ext4/ext4_common.h | 48 +++++
> fs/ext4/ext4fs.c | 219 +++++++++++++++++++
> include/ext2fs.h | 16 +-
> include/ext4fs.h | 133 ++++++++++++
> include/ext_common.h | 198 +++++++++++++++++
> 14 files changed, 1501 insertions(+), 324 deletions(-)
> create mode 100644 common/cmd_ext4.c
> create mode 100644 fs/ext4/Makefile
> create mode 100644 fs/ext4/ext4_common.c
> create mode 100644 fs/ext4/ext4_common.h
> create mode 100644 fs/ext4/ext4fs.c
> create mode 100644 include/ext4fs.h
> create mode 100644 include/ext_common.h
Oops. No, I cannot apply this. When I enable CONFIG_CMD_EXT4 in a
board config file, I get this:
+ ./MAKEALL TQM860L
Configuring for TQM860L board...
common/libcommon.o: In function `do_ext4_load':
/home/wd/git/u-boot/work/common/cmd_ext4.c:143: undefined reference to `ext2fs_set_blk_dev'
common/libcommon.o: In function `do_ext4_ls':
/home/wd/git/u-boot/work/common/cmd_ext4.c:220: undefined reference to `ext2fs_set_blk_dev'
fs/ext4/libext4fs.o: In function `ext4fs_read_file':
/home/wd/git/u-boot/work/fs/ext4/ext4fs.c:152: undefined reference to `ext2fs_devread'
/home/wd/git/u-boot/work/fs/ext4/ext4fs.c:178: undefined reference to `ext2fs_devread'
/home/wd/git/u-boot/work/fs/ext4/ext4fs.c:192: undefined reference to `ext2fs_devread'
fs/ext4/libext4fs.o: In function `ext4fs_ls':
/home/wd/git/u-boot/work/fs/ext4/ext4fs.c:211: undefined reference to `ext2fs_find_file'
/home/wd/git/u-boot/work/fs/ext4/ext4fs.c:218: undefined reference to `ext2fs_iterate_dir'
fs/ext4/libext4fs.o: In function `ext4fs_blockgroup':
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1479: undefined reference to `ext2fs_devread'
fs/ext4/libext4fs.o: In function `ext4fs_read_inode':
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1506: undefined reference to `ext2fs_devread'
fs/ext4/libext4fs.o: In function `ext4fs_get_extent_block':
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1457: undefined reference to `ext2fs_devread'
fs/ext4/libext4fs.o: In function `read_allocated_block':
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1601: undefined reference to `ext2fs_devread'
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1648: undefined reference to `ext2fs_devread'
fs/ext4/libext4fs.o:/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1686: more undefined references to `ext2fs_devread' follow
fs/ext4/libext4fs.o: In function `ext4fs_open':
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1876: undefined reference to `ext2fs_find_file'
fs/ext4/libext4fs.o: In function `ext4fs_mount':
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1907: undefined reference to `ext2fs_devread'
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1934: undefined reference to `inode_size'
/home/wd/git/u-boot/work/fs/ext4/ext4_common.c:1936: undefined reference to `ext2fs_root'
make: *** [/work/wd/tmp-ppc/u-boot] Error 1
It seems this happens when you only enable CONFIG_CMD_EXT4, without
explicitly enabling CONFIG_CMD_EXT2 as well. Please fix this - if the
ext4 code needs ext2, then it should automatically enable this option.
Hm... How much code duplication (for ext2 and ext4 commands) does this
cause?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The trouble with our times is that the future is not what it used to
be. - Paul Valery
next prev parent reply other threads:[~2012-01-05 15:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 17:39 [U-Boot] [PATCH 1/2] ext4fs ls load support uma.shankar at samsung.com
2011-12-15 22:48 ` Graeme Russ
2011-12-16 16:30 ` Mike Frysinger
2011-12-28 2:22 ` [U-Boot] [PATCH V3 " uma.shankar at samsung.com
2012-01-05 15:25 ` Wolfgang Denk
2012-01-05 15:32 ` Wolfgang Denk [this message]
2012-01-08 4:26 ` Mike Frysinger
2012-01-09 17:54 ` [U-Boot] [PATCH V4 " uma.shankar at samsung.com
2012-03-22 15:49 ` Rob Herring
2012-03-27 15:10 ` Rob Herring
2012-05-25 15:51 ` [U-Boot] [PATCH V5 " Uma Shankar
2012-08-09 21:50 ` Wolfgang Denk
2012-08-09 23:52 ` Rob Herring
2012-08-10 0:07 ` Marek Vasut
2012-08-10 6:24 ` Wolfgang Denk
2012-08-13 11:52 ` Wolfgang Denk
2012-08-13 18:28 ` Rob Herring
2012-08-13 19:17 ` Wolfgang Denk
2012-08-13 20:30 ` Rob Herring
2012-09-02 11:36 ` Wolfgang Denk
2012-09-02 16:48 ` Marek Vasut
2012-09-02 21:34 ` Rob Herring
2012-09-12 22:49 ` Tom Rini
2012-09-12 22:57 ` Rob Herring
2012-09-13 0:53 ` Tom Rini
2012-09-13 9:20 ` Marek Vasut
2012-09-13 14:29 ` Tom Rini
2012-09-20 18:34 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105153201.C48E91FD3DA@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.