From: Andy Whitcroft <apw@canonical.com>
To: Marco Navarra <fromenglish@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Checkpatch possible false positive
Date: Thu, 5 Jan 2012 19:21:29 +0000 [thread overview]
Message-ID: <20120105192129.GE13467@shadowen.org> (raw)
In-Reply-To: <20111222183928.GB16245@europa.casa.lan>
On Thu, Dec 22, 2011 at 07:39:29PM +0100, Marco Navarra wrote:
> Hello
>
> after running checkpatch on some files, it returns "ERROR: Macros with
> complex values should be enclosed in parenthesis" while processing
> code like this:
> #define SOMEVALUE 'x'
>
> It happens on agpgart.h, checkpatch complains about line 30 that
> corresponds to:
> #define AGPIOC_BASE 'A'
> Running it on elf.h returns the same error on these lines
> #define ELFMAG1 'E'
> #define ELFMAG2 'L'
> #define ELFMAG3 'F'
>
> Do you think this could be a false positive?
> The tree is linux-next and checkaptch version is 0.32
It does seem likley this is something which can be without ()'s. I will
see if we can stop it being picked up.
-apw
prev parent reply other threads:[~2012-01-05 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 18:39 Checkpatch possible false positive Marco Navarra
2012-01-05 19:21 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105192129.GE13467@shadowen.org \
--to=apw@canonical.com \
--cc=fromenglish@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.