From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: rip out the HWSTAM missed irq workaround Date: Thu, 5 Jan 2012 23:29:01 +0000 Message-ID: <20120105232901.GA9925@cloud01> References: <1325702445-2231-1-git-send-email-daniel.vetter@ffwll.ch> <1325801514-2129-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id 12D69A09ED for ; Thu, 5 Jan 2012 15:28:00 -0800 (PST) Content-Disposition: inline In-Reply-To: <1325801514-2129-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Thu, Jan 05, 2012 at 11:11:53PM +0100, Daniel Vetter wrote: > With the new ducttape of much finer quality, this seems to be no > longer necessary. > > Tested on my ivb and snb machine with the usual suspects of testcases. > > Signed-Off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_irq.c | 11 ----------- > 1 files changed, 0 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index b9ba180..af54153 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1779,17 +1779,6 @@ static void ironlake_irq_preinstall(struct drm_device *dev) > INIT_WORK(&dev_priv->rps_work, gen6_pm_rps_work); > > I915_WRITE(HWSTAM, 0xeffe); > - if (IS_GEN6(dev) || IS_GEN7(dev)) { > - /* Workaround stalls observed on Sandy Bridge GPUs by > - * making the blitter command streamer generate a > - * write to the Hardware Status Page for > - * MI_USER_INTERRUPT. This appears to serialize the > - * previous seqno write out before the interrupt > - * happens. > - */ > - I915_WRITE(GEN6_BLITTER_HWSTAM, ~GEN6_BLITTER_USER_INTERRUPT); > - I915_WRITE(GEN6_BSD_HWSTAM, ~GEN6_BSD_USER_INTERRUPT); > - } > > /* XXX hotplug from PCH */ > I'd prefer just reverting the old commits instead of this, but that's just me. Reviewed-and-Tested-by: Ben Widawsky