All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon: fix trailing whitespace
Date: Fri, 06 Jan 2012 03:33:34 +0000	[thread overview]
Message-ID: <20120106033334.GA11821@ericsson.com> (raw)
In-Reply-To: <1325798636-11819-1-git-send-email-fransmeulenbroeks@gmail.com>

Hi Frans,

On Thu, Jan 05, 2012 at 04:23:56PM -0500, Frans Meulenbroeks wrote:
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> ---
>  drivers/hwmon/adm1025.c   |    2 +-
>  drivers/hwmon/ds1621.c    |    6 +++---
>  drivers/hwmon/g760a.c     |    2 +-
>  drivers/hwmon/hwmon-vid.c |    2 +-
>  drivers/hwmon/lm78.c      |   10 +++++-----
>  drivers/hwmon/lm83.c      |    2 +-
>  drivers/hwmon/max1619.c   |    2 +-
>  drivers/hwmon/sis5595.c   |    4 ++--
>  drivers/hwmon/smsc47m1.c  |    2 +-
>  drivers/hwmon/w83627hf.c  |    2 +-
>  drivers/hwmon/w83l785ts.c |    2 +-
>  11 files changed, 18 insertions(+), 18 deletions(-)
> 
Your other patches are fine, but this one has checkpatch errors and warnings:

ERROR: code indent should use tabs where possible
#793: FILE: drivers/hwmon/hwmon-vid.c:122:
+^I^I                       1850 - val * 25;$

ERROR: code indent should use tabs where possible
#812: FILE: drivers/hwmon/hwmon-vid.c:137:
+^I^I                     2050 - (val) * 50;$

WARNING: please, no spaces at the start of a line
#1276: FILE: drivers/hwmon/ds1621.c:6:
+    Ported to Linux 2.6 by Aurelien Jarno <aurelien@aurel32.net> with$

WARNING: please, no spaces at the start of a line
#1300: FILE: drivers/hwmon/g760a.c:8:
+      http://www.gmt.com.tw/product/datasheet/EDS-760A.pdf$

total: 2 errors, 2 warnings, 607 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

While those were already there in the original files, it doesn't really help much
to only remove the spaces at the end of the line. And newly submitted patches should
not have any checkpatch errors or warnings.

I enqueued the other patches for one of the rc candidates.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2012-01-06  3:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05 21:23 [lm-sensors] [PATCH] drivers/hwmon: fix trailing whitespace Frans Meulenbroeks
2012-01-06  3:33 ` Guenter Roeck [this message]
2012-01-06  7:32 ` Frans Meulenbroeks
2012-01-06  8:12 ` Jean Delvare
2012-01-06  8:35 ` Frans Meulenbroeks
2012-01-06 14:44 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120106033334.GA11821@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.