All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	intel-gfx@lists.freedesktop.org,
	Wang Zhenyu <zhenyu.z.wang@intel.com>
Subject: Re: [PATCH] drm/i915: add an "off-dvi" HDMI audio mode
Date: Fri, 6 Jan 2012 07:08:33 -0800	[thread overview]
Message-ID: <20120106070833.2fcaee82@jbarnes-desktop> (raw)
In-Reply-To: <20120106032640.GA6171@localhost>

On Fri, 6 Jan 2012 11:26:40 +0800
Wu Fengguang <fengguang.wu@intel.com> wrote:

> Andrea,
> 
> Would you test this patch at convenient time?
> 
> Thanks,
> Fengguang
> 
> ---
> Subject: drm/i915: add an "off-dvi" HDMI audio mode
> Date: Fri Jan 06 11:04:00 CST 2012
> 
> When HDMI-DVI converter is used, it's not only necessary to turn off
> audio, but also to disable HDMI_MODE_SELECT and video infoframe. Since
> the DVI mode is mainly tied to audio functionality from end user POV,
> add a new "off-dvi" audio mode:
> 
> 	xrandr --output HDMI1 --set audio off-dvi
> 
> Reported-by: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---

My only complaint here is that off-dvi isn't an intuitive name.  We
don't have any better way of detecting an HDMI->DVI converter with
other EDID bits perhaps?

A better name might be off-dvi-mode or off-dvi-only or something.

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2012-01-06 15:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1325272048-28597-1-git-send-email-aarcange@redhat.com>
2011-12-31  1:28 ` force DVI mode without audio Wu Fengguang
     [not found]   ` <20111231122010.GA4172@redhat.com>
2011-12-31 12:49     ` Wu Fengguang
     [not found]       ` <20111231131113.GC4172@redhat.com>
2012-01-06  3:26         ` [PATCH] drm/i915: add an "off-dvi" HDMI audio mode Wu Fengguang
2012-01-06 15:08           ` Jesse Barnes [this message]
2012-01-07 13:39             ` Wu Fengguang
2012-01-11  7:01               ` Wu Fengguang
     [not found]             ` <20120106161257.GI28604@redhat.com>
2012-01-07 13:44               ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120106070833.2fcaee82@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=aarcange@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=zhenyu.z.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.