From: Tejun Heo <tj@kernel.org>
To: Namhyung Kim <namhyung.kim@lge.com>
Cc: axboe@kernel.dk, mingo@redhat.com, rostedt@goodmis.org,
fweisbec@gmail.com, teravest@google.com, slavapestov@google.com,
ctalbott@google.com, dhsharp@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCHSET RESEND] ioblame: statistical IO analyzer
Date: Fri, 6 Jan 2012 08:33:33 -0800 [thread overview]
Message-ID: <20120106163333.GI6276@google.com> (raw)
In-Reply-To: <20120106160235.GH6276@google.com>
Hello, again.
On Fri, Jan 06, 2012 at 08:02:35AM -0800, Tejun Heo wrote:
> Hmmm... originally, I had variable length data structure there but now
> it's fixed so exposing them using tracepoint shouldn't be too
> difficult and could actually be better (previously it didn't really
> fit TP and ringbuffer should be used directly). Yeah, that's a
> thought. Generating a TP event per IO shouldn't be taxing and it
> would give much better visibility to userland and we can drop the
> whole statics configuration and stuff. Enticing. I'll think more
> about it.
The more I think about it, the better it seems. I ended up putting
the statistics gathering inside the kernel mostly because the
information I had at IO completion wasn't too fit to export to
userland verbatim, but while iterating the implementation those parts
got chopped (it was necessary for statistics too anyway) and now it
seems I can just replace the whole thing with a single tracepoint and
drop the whole configurable statistics stuff along with act and its
reclaiming, and silly _bin interface. That's just sweeet. Someohw I
completely missed the transition of the information available at IO
completion.
I might be missing something important but will give it a shot and, if
it goes as expected, post updated series soon.
Thanks a lot for bringing it up. :)
--
tejun
prev parent reply other threads:[~2012-01-06 16:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 23:42 [RFC PATCHSET RESEND] ioblame: statistical IO analyzer Tejun Heo
2012-01-05 23:42 ` [PATCH 01/11] trace_event_filter: factorize filter creation Tejun Heo
2012-01-05 23:42 ` [PATCH 02/11] trace_event_filter: add trace_event_filter_*() interface Tejun Heo
2012-01-05 23:42 ` [PATCH 03/11] block: block_bio_complete tracepoint was missing Tejun Heo
2012-01-09 1:30 ` Namhyung Kim
2012-01-09 1:49 ` Tejun Heo
2012-01-09 2:33 ` Namhyung Kim
2012-01-05 23:42 ` [PATCH 04/11] block: add @req to bio_{front|back}_merge tracepoints Tejun Heo
2012-01-05 23:42 ` [PATCH 05/11] block: abstract disk iteration into disk_iter Tejun Heo
2012-01-05 23:42 ` [PATCH 06/11] writeback: move struct wb_writeback_work to writeback.h Tejun Heo
2012-01-05 23:42 ` [PATCH 07/11] writeback: add more tracepoints Tejun Heo
2012-01-05 23:42 ` [PATCH 08/11] block: add block_touch_buffer tracepoint Tejun Heo
2012-01-05 23:42 ` [PATCH 09/11] vfs: add fcheck tracepoint Tejun Heo
2012-01-05 23:42 ` [PATCH 10/11] stacktrace: implement save_stack_trace_quick() Tejun Heo
2012-01-05 23:42 ` [PATCH 11/11] block, trace: implement ioblame IO statistical analyzer Tejun Heo
2012-01-06 9:00 ` [RFC PATCHSET RESEND] ioblame: statistical IO analyzer Namhyung Kim
2012-01-06 16:02 ` Tejun Heo
2012-01-06 16:33 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106163333.GI6276@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=ctalbott@google.com \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung.kim@lge.com \
--cc=rostedt@goodmis.org \
--cc=slavapestov@google.com \
--cc=teravest@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.