From: arnd.bergmann@linaro.org (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] at91 : move pm.h header to arch/arm/include/asm
Date: Fri, 6 Jan 2012 17:30:33 +0000 [thread overview]
Message-ID: <201201061730.33525.arnd.bergmann@linaro.org> (raw)
In-Reply-To: <1325864915-794-1-git-send-email-daniel.lezcano@linaro.org>
On Friday 06 January 2012, Daniel Lezcano wrote:
> Move the location of the pm.h header file to the include directory,
> so it can be included from another place from the current one.
>
> That will allow the next patch which moves the cpuidle code to the
> drivers/cpuidle directory.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> arch/arm/{mach-at91/pm.h => include/asm/at91_pm.h} | 0
> arch/arm/mach-at91/cpuidle.c | 2 +-
> arch/arm/mach-at91/pm.c | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename arch/arm/{mach-at91/pm.h => include/asm/at91_pm.h} (100%)
Moving the driver is great, as we have previously discussed, but
the header file does not belong into include/asm really, because it
is too hardware specific and we are trying to keep such stuff out
of that place.
One option would be to move the pm.c along with the cpuidle.c file,
in particular that might turn out to be a good idea if other
platforms have the same requirement.
Aside from that, it would be good to hear from the AT91 maintainers
how they want to deal with the removal of CONFIG_ARCH_AT91_*
conditionals, which AFACIT will be necessary anyway in order to allow
building a single kernel across multiple at91 targets. Once that
problem is solved for pm.h, the question of where to place that header
may be resolved, too.
Arnd
next prev parent reply other threads:[~2012-01-06 17:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 15:48 [PATCH 1/2] at91 : move pm.h header to arch/arm/include/asm Daniel Lezcano
2012-01-06 15:48 ` [PATCH 2/2] at91 : move cpuidle driver to drivers/cpuidle directory Daniel Lezcano
2012-01-06 17:30 ` Arnd Bergmann [this message]
2012-01-06 23:19 ` [PATCH 1/2] at91 : move pm.h header to arch/arm/include/asm Daniel Lezcano
2012-01-09 11:19 ` Daniel Lezcano
2012-01-09 11:29 ` Russell King - ARM Linux
2012-01-09 13:54 ` Daniel Lezcano
2012-01-09 14:44 ` Russell King - ARM Linux
2012-01-09 15:00 ` Daniel Lezcano
2012-01-09 16:48 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-09 17:09 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-09 17:41 ` Nicolas Ferre
2012-01-09 14:46 ` Rob Herring
2012-01-09 15:08 ` Daniel Lezcano
2012-01-07 10:45 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201061730.33525.arnd.bergmann@linaro.org \
--to=arnd.bergmann@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.