From: 'Greg KH' <greg@kroah.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Stephen Rothwell' <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
'Nicolas Pitre' <nicolas.pitre@linaro.org>,
'Russell King' <rmk@arm.linux.org.uk>,
'Kay Sievers' <kay.sievers@vrfy.org>
Subject: Re: linux-next: manual merge of the driver-core tree with the arm tree
Date: Fri, 6 Jan 2012 11:20:02 -0800 [thread overview]
Message-ID: <20120106192002.GA24244@kroah.com> (raw)
In-Reply-To: <031201cccc41$f24aa320$d6dfe960$%kim@samsung.com>
On Fri, Jan 06, 2012 at 04:08:09PM +0900, Kukjin Kim wrote:
> Stephen Rothwell wrote:
> >
> > Hi Greg,
> >
> > Today's linux-next merge of the driver-core tree got a conflict in
> > arch/arm/mach-s5pc100/common.c between commit 109ac862f737 ("ARM:
> > mach-s5pc100: use standard arch_idle()") from the arm tree and commit
> > 4a858cfc9af8 ("arm: convert sysdev_class to a regular subsystem") from
> > the driver-core tree.
> >
> > I fixed it up (see below) and can carry the fix as necessary.
> >
> > --
> > Cheers,
> > Stephen Rothwell sfr@canb.auug.org.au
> >
> > diff --cc arch/arm/mach-s5pc100/common.c
> > index 4659fb9,af52c09..0000000
> > --- a/arch/arm/mach-s5pc100/common.c
> > +++ b/arch/arm/mach-s5pc100/common.c
> > @@@ -194,27 -154,17 +195,27 @@@ static struct device s5pc100_dev =
> >
> > static int __init s5pc100_core_init(void)
> > {
> > - return sysdev_class_register(&s5pc100_sysclass);
> > + return subsys_system_register(&s5pc100_subsys, NULL);
> > }
> > -
> > core_initcall(s5pc100_core_init);
> >
> > int __init s5pc100_init(void)
> > {
> > printk(KERN_INFO "S5PC100: Initializing architecture\n");
> > - return sysdev_register(&s5pc100_sysdev);
> > ++ return device_register(&s5pc100_sys);
>
> Hi Greg,
>
> Should be 'return device_register(&s5pc100_dev);'?
>
> Greg,
> Following should be fixed in your driver-core/driver-core-next.
> (I informed that but maybe you missed)
Sorry, I missed this patch. I'll apply it and take the above merge fix
as well.
greg k-h
next prev parent reply other threads:[~2012-01-06 19:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 6:52 linux-next: manual merge of the driver-core tree with the arm tree Stephen Rothwell
2012-01-06 7:08 ` Kukjin Kim
2012-01-06 19:20 ` 'Greg KH' [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-06 6:57 Stephen Rothwell
2012-01-06 7:13 ` Kukjin Kim
2011-12-28 5:40 Stephen Rothwell
2012-01-04 23:08 ` Greg KH
2011-12-28 5:35 Stephen Rothwell
2012-01-04 23:08 ` Greg KH
2011-12-28 5:12 Stephen Rothwell
2011-12-28 5:24 ` Stephen Rothwell
2012-01-04 23:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106192002.GA24244@kroah.com \
--to=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=rmk@arm.linux.org.uk \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.