Re: [PATCH 4/6] x86: initial support for sta2x11

[Alessandro Rubini <rubini@gnudd.com>]

> trivia:

Thanks.

> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

Ok.

> typo: s/subordindate/subordinate/

argh!

> It's probably not necessary to prefix with "sta2x11: "

fine.

> 
>> +			 size);
>> +		if (swiotlb_late_init_with_default_size(size))
>> +			dev_emerg(&pdev->dev, "%s: init swiotlb(%i) failed\n",
>> +				  __func__, size);
> 
> or __func__

I don't understand. No size? Or you typoed and meant pr_fmt defined above?

>> +	uint32_t v[2]; /* used as a string... */
> 
> less than pretty.

Sure. But it's informative. Do you prefer a union? I don't want to
do be/le stuff as it's irrelevant. But I can't read 1 byte at a time
nor use a pointer there.

thanks, will resend

/alessandro