From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91: fix at91rm9200 soc subtype handling
Date: Sat, 7 Jan 2012 12:19:29 +0100 [thread overview]
Message-ID: <20120107111929.GC2854@game.jcrosoft.org> (raw)
In-Reply-To: <1325070604-5560-1-git-send-email-veli-pekka.peltola@bluegiga.com>
On 13:10 Wed 28 Dec , Veli-Pekka Peltola wrote:
> BGA should be the default SoC subtype but it is set to unknown if
> not explicitly set to PQFP. Currently setting it to PQFP sets subtype
> to BGA as subtypes are swapped in at91rm9200_set_type().
>
> Wrong subtype causes GPIO bank D not to work at all.
>
> After this fix BGA subtype is set as default. On boot BGA is printed
> always but it is set to PQFP if requested before setting amount of GPIO
> banks.
>
> Signed-off-by: Veli-Pekka Peltola <veli-pekka.peltola@bluegiga.com>
> ---
> arch/arm/mach-at91/setup.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c
> index aa64294..e6b07ad 100644
> --- a/arch/arm/mach-at91/setup.c
> +++ b/arch/arm/mach-at91/setup.c
> @@ -27,9 +27,9 @@ EXPORT_SYMBOL(at91_soc_initdata);
> void __init at91rm9200_set_type(int type)
> {
> if (type == ARCH_REVISON_9200_PQFP)
> - at91_soc_initdata.subtype = AT91_SOC_RM9200_BGA;
> - else
> at91_soc_initdata.subtype = AT91_SOC_RM9200_PQFP;
> + else
> + at91_soc_initdata.subtype = AT91_SOC_RM9200_BGA;
> }
>
> void __init at91_init_irq_default(void)
> @@ -118,6 +118,7 @@ static void __init soc_detect(u32 dbgu_base)
>
> case ARCH_ID_AT91RM9200:
> at91_soc_initdata.type = AT91_SOC_RM9200;
> + at91_soc_initdata.subtype = AT91_SOC_RM9200_BGA;
> at91_boot_soc = at91rm9200_soc;
disagree here
as we can not detect it the board MUST set it
Best Regards,
J.
prev parent reply other threads:[~2012-01-07 11:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 11:10 [PATCH] at91: fix at91rm9200 soc subtype handling Veli-Pekka Peltola
2012-01-02 14:21 ` Nicolas Ferre
2012-01-03 9:23 ` Nicolas Ferre
2012-01-03 11:38 ` [PATCH v2] ARM: " Nicolas Ferre
2012-01-07 11:21 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-07 11:20 ` [PATCH] " Jean-Christophe PLAGNIOL-VILLARD
2012-01-07 11:19 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107111929.GC2854@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.