From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cyril Brulebois <kibi@debian.org>
Subject: Re: [PATCH 1/2] drm/i915: simplify pipe checking
Date: Sun, 8 Jan 2012 03:01:12 +0100
Message-ID: <20120108020112.GC1531@mraw.org>
References: <1325986835-12717-1-git-send-email-eugeni.dodonov@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0793436079=="
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from glenfiddich.mraw.org (glenfiddich.mraw.org [88.191.124.82])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5E5849EE9A
	for <intel-gfx@lists.freedesktop.org>;
	Sat,  7 Jan 2012 18:01:15 -0800 (PST)
In-Reply-To: <1325986835-12717-1-git-send-email-eugeni.dodonov@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Eugeni Dodonov <eugeni.dodonov@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org


--===============0793436079==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="aT9PWwzfKXlsBJM1"
Content-Disposition: inline


--aT9PWwzfKXlsBJM1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Eugeni Dodonov <eugeni.dodonov@intel.com> (07/01/2012):
> This is also handled by i915_reg.h, so just reuse this trick to reduce
> universe enthropy.

entropy.

Besides that:

Reviewed-by: Cyril Brulebois <kibi@debian.org>

> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  drivers/gpu/drm/i915/i915_suspend.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i=
915_suspend.c
> index 7886e4f..c0b945c 100644
> --- a/drivers/gpu/drm/i915/i915_suspend.c
> +++ b/drivers/gpu/drm/i915/i915_suspend.c
> @@ -28,6 +28,7 @@
>  #include "drm.h"
>  #include "i915_drm.h"
>  #include "intel_drv.h"
> +#include "i915_reg.h"
> =20
>  static bool i915_pipe_enabled(struct drm_device *dev, enum pipe pipe)
>  {
> @@ -35,7 +36,7 @@ static bool i915_pipe_enabled(struct drm_device *dev, e=
num pipe pipe)
>  	u32	dpll_reg;
> =20
>  	if (HAS_PCH_SPLIT(dev))
> -		dpll_reg =3D (pipe =3D=3D PIPE_A) ? _PCH_DPLL_A : _PCH_DPLL_B;
> +		dpll_reg =3D PCH_DPLL(pipe);
>  	else
>  		dpll_reg =3D (pipe =3D=3D PIPE_A) ? _DPLL_A : _DPLL_B;
> =20

Mraw,
KiBi.

--aT9PWwzfKXlsBJM1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8I+OUACgkQeGfVPHR5Nd1F0gCcCk+qNWKwt4rLr8Cxh/bFfmSw
FkYAoNIJn87BrANwkA2Uvs8WmI6YXlBM
=rgvp
-----END PGP SIGNATURE-----

--aT9PWwzfKXlsBJM1--

--===============0793436079==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============0793436079==--