All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting
Date: Sun, 8 Jan 2012 17:02:59 +0100	[thread overview]
Message-ID: <201201081702.59630.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAFEAcA8XqcG+US2s33_sRVR4mkqxFZZPWy4akkMJq_u7ktW=KQ@mail.gmail.com>

> On 7 January 2012 20:56, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> On 7 January 2012 20:11, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> > The AMBA IDs are supposed to be at the end of 0x2000 block, which the
> >> > PL011 UART allocates. Current QEMU implementation puts those IDs at
> >> > 0x1000 offset, which is wrong. The QEMU implementation also allocates
> >> > only 0x1000 instead of 0x2000 of space.
> >> 
> >> Why do you think this change is correct? The PL011 TRM
> >> http://infocenter.arm.com/help/topic/com.arm.doc.ddi0183g/I18381.html
> >> says the ID registers are at 0xFE0..0xFFC.
> >> and for instance on the PBX-A9 devboard:
> >> http://infocenter.arm.com/help/topic/com.arm.doc.dui0440b/Bbajihec.html
> >> the UARTs are at 0x10009000, 0x1000A000, 0x1000B000, 0x1000C000, so
> >> they clearly can't be 0x2000 in size.
> > 
> > Then we have a problem, because eg. on freescale mx28 they are 0x2000
> > big. The only conclusion I can draw from this is that the size of the
> > segment that can be assigned to PL011 is variable and the ID-octet is
> > always at the end.
> 
> Can you point me to some documentation? I looked at
> http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch=1&s
> r=7 (i.MX28 Applications Processor Reference Manual) and although it has a
> number of UARTs none of them looked obviously like PL011s.

That's it, look at DUART section and Memory map section.

M
> 
> -- PMM

  reply	other threads:[~2012-01-08 16:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 20:11 [Qemu-devel] [PATCH] PL011: Fix ID reporting Marek Vasut
2012-01-07 20:38 ` Peter Maydell
2012-01-07 20:56   ` Marek Vasut
2012-01-08 14:36     ` Peter Maydell
2012-01-08 16:02       ` Marek Vasut [this message]
2012-01-08 16:21         ` Peter Maydell
2012-01-08 16:57           ` Marek Vasut
2012-01-08 17:10             ` Peter Maydell
2012-01-08 19:44               ` Marek Vasut
2012-01-08 21:36                 ` Peter Maydell
2012-01-08 23:59                   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201081702.59630.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.