From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC][PATCH 1/3] dmaengine: shdma: add .no_error_irq flag
Date: Mon, 09 Jan 2012 02:00:32 +0000 [thread overview]
Message-ID: <20120109020031.GI25648@linux-sh.org> (raw)
In-Reply-To: <4F0537F2.4080306@renesas.com>
On Fri, Jan 06, 2012 at 01:00:25PM +0900, Shimoda, Yoshihiro wrote:
> Hello Guennadi-san,
>
> Thank you very much for your review and suggestion.
> I think that your suggestion is very good.
>
> So, I could remove the no_error_irq flag using platform_get_irq_byname().
> My modified patch is the following. And, if it is no problem,
> I will submit it again:
> -------
> Subject: [PATCH] dmaengine: shdma: modify the DMAC Address Error registration
>
> The USB-DMAC/SUDMAC don't have the interrupt of DMAC Address Error.
> So, only when the resource has a name and it is "error_irq", the driver
> calls request_irq() for DMAC Address Error.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
If we're going to do this it would be nice to adopt the same behaviour
for the generic DMAE IRQ, too (then we can finally get rid of those silly
CPU_SH4 || ARCH_SHMOBILE ifdefs).
This approach looks like an improvement to me at least.
next prev parent reply other threads:[~2012-01-09 2:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 5:41 [RFC][PATCH 1/3] dmaengine: shdma: add .no_error_irq flag Shimoda, Yoshihiro
2012-01-05 9:01 ` Guennadi Liakhovetski
2012-01-06 4:00 ` Shimoda, Yoshihiro
2012-01-09 2:00 ` Paul Mundt [this message]
2012-01-10 0:47 ` Shimoda, Yoshihiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109020031.GI25648@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.