All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Laxman Dewangan <ldewangan.com@nvidia.com>,
	"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH V1] TPS62360: Add tps62360 regulator driver
Date: Mon, 9 Jan 2012 00:48:46 -0800	[thread overview]
Message-ID: <20120109084845.GA15277@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <96C9D994977DD0439FB6D3FE3B13DD907DBDABA9D6@BGMAIL01.nvidia.com>

On Mon, Jan 09, 2012 at 02:17:17PM +0530, Laxman Dewangan wrote:
> > On Monday, January 09, 2012 1:09 PM, Mark Brown wrote

> > The driver can decide what voltages to set - like I said in a previous
> > mail it could use something like LRU to decide which slot to use, or
> > perhaps be clever with the upper end of the range it was given.

> So we will change the gpios output also according to voltage register
> slot from driver?

You'd need to change both from the driver.

> So through platform data, I will pass the gpio nr for VSEL0, VSEL1 and
> their default state. 

Yes.

> If valid gpios will be passed then driver will use the LRU mechanism
> for getting desired configuration register for configuring the desired
> voltage (passed through the regulator_setvoltage())and set the gpios
> accordingly through gpio libs.
> In this approach, because we need to set two different gpios for
> desired logic, the output will not go in proper transition from
> current to new one, for some time when we completed setting of
> one gpio and setting second gpio.

Isn't that an issue anyway?

  reply	other threads:[~2012-01-09  8:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04  9:20 [PATCH V1] TPS62360: Add tps62360 regulator driver Laxman Dewangan
2012-01-04  9:20 ` Laxman Dewangan
2012-01-05  6:29 ` Mark Brown
2012-01-05 13:48   ` Laxman Dewangan
2012-01-06 17:44     ` Mark Brown
     [not found]     ` <96C9D994977DD0439FB6D3FE3B13DD907DBD3A9E9B-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-06 18:57       ` Mark Brown
2012-01-06 18:57         ` Mark Brown
     [not found]         ` <20120106185755.GC2893-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-07 17:46           ` Laxman Dewangan
2012-01-07 17:46             ` Laxman Dewangan
     [not found]             ` <96C9D994977DD0439FB6D3FE3B13DD907DBD3AA0DE-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-07 19:10               ` Mark Brown
2012-01-07 19:10                 ` Mark Brown
2012-01-08  7:42                 ` Laxman Dewangan
     [not found]                   ` <96C9D994977DD0439FB6D3FE3B13DD907DBD3AA0E4-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-08 16:58                     ` Mark Brown
2012-01-08 16:58                       ` Mark Brown
     [not found]                       ` <20120108165819.GB29065-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-09  7:04                         ` Laxman Dewangan
2012-01-09  7:04                           ` Laxman Dewangan
2012-01-09  7:11                           ` Mark Brown
     [not found]                             ` <20120109071128.GA22134-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-09  7:33                               ` Laxman Dewangan
2012-01-09  7:33                                 ` Laxman Dewangan
     [not found]                                 ` <96C9D994977DD0439FB6D3FE3B13DD907DBDABA9B6-kdsAE/FnitNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-09  7:39                                   ` Mark Brown
2012-01-09  7:39                                     ` Mark Brown
     [not found]                                     ` <20120109073859.GG22134-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-01-09  8:47                                       ` Laxman Dewangan
2012-01-09  8:47                                         ` Laxman Dewangan
2012-01-09  8:48                                         ` Mark Brown [this message]
2012-01-09  9:19                                           ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120109084845.GA15277@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=ldewangan.com@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.