From: Greg KH <greg@kroah.com>
To: Youquan Song <youquan.song@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
a.p.zijlstra@chello.nl, tglx@linutronix.de, hpa@zytor.com,
akpm@linux-foundation.org, stable@vger.kernel.org,
suresh.b.siddha@intel.com, arjan@linux.intel.com,
len.brown@intel.com, anhua.xu@intel.com, chaohong.guo@intel.com,
Youquan Song <youquan.song@linux.intel.com>
Subject: Re: [PATCH] x86,sched: Fix sched_smt_power_savings totally broken
Date: Mon, 9 Jan 2012 07:37:58 -0800 [thread overview]
Message-ID: <20120109153758.GC9329@kroah.com> (raw)
In-Reply-To: <1326099367-4166-1-git-send-email-youquan.song@intel.com>
On Mon, Jan 09, 2012 at 04:56:07PM +0800, Youquan Song wrote:
> sched_smt_power_savings is totally broken at lastest linux and -tip tree.
>
> sched_smt_power_savings is set to 1, the scheduler tries to schedule processes
> on the least number of hyper-threads on a core as possible. In other words,
> the process load is distributed such that all the hyper-threads in a core and
> all the cores within the same processor are busy before the load is distributed
> to other hyper-threads and cores in another processor.
>
> Test On Intel Xeon machine with 2 physical CPUs and each CPU has 8 cores / 16
> threads. physical CPU 0 includes cpu[0~7] and cpu[16~23]; while physical CPU 1
> includes cpu[8~15] and cpu[24~31].
>
> At latest -tip tree:
> echo 1 > /sys/devices/system/cpu/sched_smt_power_savings
> ./ebizzy -t 16 -S 100 & sleep 10 ; cat /proc/sched_debug | grep -A 1 cpu# > tmp.log
>
> cpu#0, 2693.564 MHz
> .nr_running : 0
> --
> cpu#1, 2693.564 MHz
> .nr_running : 1
> --
> cpu#2, 2693.564 MHz
> .nr_running : 0
> --
> cpu#3, 2693.564 MHz
> .nr_running : 1
> --
> cpu#4, 2693.564 MHz
> .nr_running : 1
> --
> cpu#5, 2693.564 MHz
> .nr_running : 1
> --
> cpu#6, 2693.564 MHz
> .nr_running : 1
> --
> cpu#7, 2693.564 MHz
> .nr_running : 1
> --
> cpu#8, 2693.564 MHz
> .nr_running : 1
> --
> cpu#9, 2693.564 MHz
> .nr_running : 1
> --
> cpu#10, 2693.564 MHz
> .nr_running : 1
> --
> cpu#11, 2693.564 MHz
> .nr_running : 0
> --
> cpu#12, 2693.564 MHz
> .nr_running : 1
> --
> cpu#13, 2693.564 MHz
> .nr_running : 1
> --
> cpu#14, 2693.564 MHz
> .nr_running : 0
> --
> cpu#15, 2693.564 MHz
> .nr_running : 0
> --
> cpu#16, 2693.564 MHz
> .nr_running : 0
> --
> cpu#17, 2693.564 MHz
> .nr_running : 0
> --
> cpu#18, 2693.564 MHz
> .nr_running : 1
> --
> cpu#19, 2693.564 MHz
> .nr_running : 0
> --
> cpu#20, 2693.564 MHz
> .nr_running : 0
> --
> cpu#21, 2693.564 MHz
> .nr_running : 0
> --
> cpu#22, 2693.564 MHz
> .nr_running : 0
> --
> cpu#23, 2693.564 MHz
> .nr_running : 0
> --
> cpu#24, 2693.564 MHz
> .nr_running : 0
> --
> cpu#25, 2693.564 MHz
> .nr_running : 1
> --
> cpu#26, 2693.564 MHz
> .nr_running : 1
> --
> cpu#27, 2693.564 MHz
> .nr_running : 1
> --
> cpu#28, 2693.564 MHz
> .nr_running : 0
> --
> cpu#29, 2693.564 MHz
> .nr_running : 0
> --
> cpu#30, 2693.564 MHz
> .nr_running : 1
> --
> cpu#31, 2693.564 MHz
> .nr_running : 1
>
> >From above, we notice 16 threads are distributed among 2 physical CPUs.
> After apply the patch, 16 threads are only distributed at one physical CPU.
> In this case, we can notice 30% power saving.
> Following are the result after apply the patch:
>
> cpu#0, 2693.384 MHz
> .nr_running : 1
> --
> cpu#1, 2693.384 MHz
> .nr_running : 1
> --
> cpu#2, 2693.384 MHz
> .nr_running : 1
> --
> cpu#3, 2693.384 MHz
> .nr_running : 1
> --
> cpu#4, 2693.384 MHz
> .nr_running : 1
> --
> cpu#5, 2693.384 MHz
> .nr_running : 1
> --
> cpu#6, 2693.384 MHz
> .nr_running : 1
> --
> cpu#7, 2693.384 MHz
> .nr_running : 1
> --
> cpu#8, 2693.384 MHz
> .nr_running : 0
> --
> cpu#9, 2693.384 MHz
> .nr_running : 0
> --
> cpu#10, 2693.384 MHz
> .nr_running : 0
> --
> cpu#11, 2693.384 MHz
> .nr_running : 0
> --
> cpu#12, 2693.384 MHz
> .nr_running : 0
> --
> cpu#13, 2693.384 MHz
> .nr_running : 0
> --
> cpu#14, 2693.384 MHz
> .nr_running : 0
> --
> cpu#15, 2693.384 MHz
> .nr_running : 0
> --
> cpu#16, 2693.384 MHz
> .nr_running : 1
> --
> cpu#17, 2693.384 MHz
> .nr_running : 1
> --
> cpu#18, 2693.384 MHz
> .nr_running : 1
> --
> cpu#19, 2693.384 MHz
> .nr_running : 1
> --
> cpu#20, 2693.384 MHz
> .nr_running : 1
> --
> cpu#21, 2693.384 MHz
> .nr_running : 1
> --
> cpu#22, 2693.384 MHz
> .nr_running : 1
> --
> cpu#23, 2693.384 MHz
> .nr_running : 1
> --
> cpu#24, 2693.384 MHz
> .nr_running : 0
> --
> cpu#25, 2693.384 MHz
> .nr_running : 0
> --
> cpu#26, 2693.384 MHz
> .nr_running : 0
> --
> cpu#27, 2693.384 MHz
> .nr_running : 0
> --
> cpu#28, 2693.384 MHz
> .nr_running : 0
> --
> cpu#29, 2693.384 MHz
> .nr_running : 0
> --
> cpu#30, 2693.384 MHz
> .nr_running : 0
> --
> cpu#31, 2693.384 MHz
> .nr_running : 1
>
>
> This patch will set SMT sibling power capability to SCHED_POWER_SCALE
> (1024) when sched_smt_power_savings set. So when there is possible do power
> saving during scheduling, scheduler will truly schedule processes as
> sched_smt_power_savings should do.
>
>
> Signed-off-by: Youquan Song <youquan.song@intel.com>
> Tested-by: Anhua Xu <anhua.xu@intel.com>
> ---
> kernel/sched/fair.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
prev parent reply other threads:[~2012-01-09 15:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 8:56 [PATCH] x86,sched: Fix sched_smt_power_savings totally broken Youquan Song
2012-01-09 10:06 ` Peter Zijlstra
2012-01-09 10:28 ` Peter Zijlstra
2012-01-09 10:30 ` Peter Zijlstra
2012-01-09 11:00 ` Vaidyanathan Srinivasan
2012-01-09 14:35 ` Peter Zijlstra
2012-01-09 16:03 ` Vaidyanathan Srinivasan
2012-01-09 16:13 ` Peter Zijlstra
2012-01-09 17:05 ` Vaidyanathan Srinivasan
2012-01-09 14:13 ` Arjan van de Ven
2012-05-18 10:19 ` [tip:sched/core] sched: Remove stale power aware scheduling remnants and dysfunctional knobs tip-bot for Peter Zijlstra
2012-01-10 0:14 ` [PATCH] x86,sched: Fix sched_smt_power_savings totally broken Youquan Song
2012-01-09 11:05 ` Peter Zijlstra
2012-01-10 5:58 ` Youquan Song
2012-01-09 23:52 ` Suresh Siddha
2012-01-10 9:18 ` Ingo Molnar
2012-01-10 14:32 ` Arjan van de Ven
2012-01-10 14:41 ` Peter Zijlstra
2012-01-10 14:54 ` Arjan van de Ven
2012-01-10 15:32 ` Vincent Guittot
2012-01-10 15:32 ` Vincent Guittot
2012-01-10 16:49 ` Vaidyanathan Srinivasan
2012-01-10 19:41 ` Ingo Molnar
2012-01-10 19:44 ` Ingo Molnar
2012-01-10 16:54 ` Youquan Song
2012-01-10 16:51 ` Vaidyanathan Srinivasan
2012-01-10 19:01 ` Suresh Siddha
2012-01-11 3:52 ` Vaidyanathan Srinivasan
2012-01-11 17:37 ` Youquan Song
2012-01-10 16:44 ` Vaidyanathan Srinivasan
2012-01-09 11:12 ` Peter Zijlstra
2012-01-09 14:29 ` Vincent Guittot
2012-01-09 14:29 ` Vincent Guittot
2012-01-09 14:46 ` Peter Zijlstra
2012-01-10 2:12 ` Indan Zupancic
2012-01-10 9:26 ` Peter Zijlstra
2012-01-10 1:54 ` Suresh Siddha
2012-01-10 8:08 ` Vincent Guittot
2012-01-09 15:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109153758.GC9329@kroah.com \
--to=greg@kroah.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=anhua.xu@intel.com \
--cc=arjan@linux.intel.com \
--cc=chaohong.guo@intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.