All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ted Ts'o" <tytso@mit.edu>
To: Shantanu Goel <sgoel01@yahoo.com>
Cc: Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: Fix up range_end offset in range cyclic writeback
Date: Mon, 9 Jan 2012 10:50:16 -0500	[thread overview]
Message-ID: <20120109155016.GD22175@thunk.org> (raw)
In-Reply-To: <1326123988.9602.YahooMailNeo@web38004.mail.mud.yahoo.com>

On Mon, Jan 09, 2012 at 07:46:28AM -0800, Shantanu Goel wrote:
> 
> Thanks for confirming the fix is good.  We noticed that kupdate
> writebacks were happening at irregular intervals

So this was a performance issue that led you to this investigation?
How much of a performance issue are we talking about?

If it's a correctness issue that might lead to data loss because
fsync() wasn't doing its jobs, that's obviously higher priority than a
performance issue.

Again, I just wanted to characterize this correctly in the commit ---
BTW, this is good stuff to include in the commit description so in the
future, developers trying to go through the history can understand why
a particular patch is important (perhaps to backport into an
enterprise distro release, etc.)

Thanks, regards,

						- Ted

  parent reply	other threads:[~2012-01-09 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-08  3:23 [PATCH] ext4: Fix up range_end offset in range cyclic writeback Shantanu Goel
2012-01-09 15:17 ` Ted Ts'o
2012-01-09 15:49   ` Shantanu Goel
     [not found]   ` <1326123988.9602.YahooMailNeo@web38004.mail.mud.yahoo.com>
2012-01-09 15:50     ` Ted Ts'o [this message]
2012-01-09 16:20       ` Shantanu Goel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120109155016.GD22175@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sgoel01@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.