From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] Add tools/intel_infoframes Date: Mon, 9 Jan 2012 17:59:05 +0100 Message-ID: <20120109165905.GH3723@phenom.ffwll.local> References: <1326117799-32391-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DA589EB0D for ; Mon, 9 Jan 2012 08:57:02 -0800 (PST) Received: by wibhq15 with SMTP id hq15so3654672wib.36 for ; Mon, 09 Jan 2012 08:57:01 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eugeni Dodonov Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Mon, Jan 09, 2012 at 12:42:06PM -0200, Eugeni Dodonov wrote: > On Mon, Jan 9, 2012 at 12:03, wrote: > > > From: Paulo Zanoni > > > > This is a command-line tool that allows us to display and modify the > > InfoFrames we send. > > > > Signed-off-by: Paulo Zanoni > > > > Very interesting! > > I think that it would be more interesting to use command line options > instead of interactive input - something like: > -d, --dump > -c, --change [parameters] > -dd, --dip-disable > -de, --dip-enable [parameters] > -hd, --hdmi-disable > -he, --hdmi-enable [parameters] > > So this could be scripted and used non-interactively. This would also > simplify your change_avi_infoframe and parse_infoframe_option_s - you could > just pass all the values as parameters instead. I like Eugeni's suggestion - all our other dump/decode/fiddle with the hw tools are non-interactive (safe only for intel_gpu_top iirc). Can I bother you to do this? Yours, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48