[PATCH] ARM: PXA: Zipit Z2: Fix oops in z2_power_off

[marek.vasut@gmail.com (Marek Vasut)]

> On Mon, Jan 09, 2012 at 01:38:29PM +0100, Marek Vasut wrote:
> > > On Mon, Jan 09, 2012 at 01:13:31PM +0100, Marek Vasut wrote:
> > > > > 2012/1/9 Marek Vasut <marek.vasut@gmail.com>:
> > > > > >> Nope, it does not work. Looks like device disables power on
> > > > > >> memory in deepsleep.
> > > > > > 
> > > > > > Why?
> > > > > 
> > > > > In deepsleep PXA27x deasserts SYS_EN pin, and looks like when it's
> > > > > deasserted there's no power on SDRAM (on Zipit). Just guess.
> > > > 
> > > > Then maybe implement suspend-to-disk ? There was a patch for omap on
> > > > the list, maybe it's even merged.
> > > 
> > > What are hell you going on about?
> > 
> > Cool your jets Russell.
> > 
> > > Why would someone want to even try
> > > implementing suspend-to-disk in the power off hook?
> > 
> > I'm not talking about the powerdown hook anymore, but a way how to avoid
> > it as much as possible via standard means.
> 
> Maybe you should state that you are deviating from the subject of this
> email thread to aid your readers understanding?

I think it was pretty clear already. OK

> 
> > > Why would you even
> > > want to try to preserve the system state in a power off hook?
> > 
> > Not in poweroff hook. Btw. I'm still convinced the bootloader should
> > handle this -- the powerdown should just reset the thing and tell
> > bootloader to deepsleep it.
> 
> Why should the boot loader be involved?  The boot loader is all about
> bringing the system _up_, not taking it down.

Why would you bloat kernel with non-standard crap? The firmware should handle 
this if the hardware is broken (and even if this sounds acpi-ish, I still 
consider this particular thing should be handled by firmware). Especially since 
what the device does in the end is simply restart anyway.

M