From: Dave Chinner <david@fromorbit.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
mgorman@suse.de, gregkh@suse.de, akpm@linux-foundation.org
Subject: Re: [RFC PATCH] shrink_dcache_parent() deadlock
Date: Tue, 10 Jan 2012 07:59:07 +1100 [thread overview]
Message-ID: <20120109205907.GE4198@dastard> (raw)
In-Reply-To: <CA+55aFwikQQrpGoyxvY+y=B8NfKBSdcAnKME+xZh+N1TQfp8LA@mail.gmail.com>
On Mon, Jan 09, 2012 at 10:30:59AM -0800, Linus Torvalds wrote:
> On Mon, Jan 9, 2012 at 9:30 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > Resend would be nice; I can try to dig the series out and rebase it, but...
>
> Here's a TOTALLY UNTESTED rebase of just that single patch from Dave.
>
> I did not check if the rest of the series did something that this
> patch needs, so the patch may be entirely broken, but it does look
> sane on its own (ie I do not see anything obviously broken in it). So
> it still looks like a nice cleanup, but maybe I'm missing something
> subtle, and maybe the rest of Dave's series really is required.
Nothing else is required - that patch is a OK by itself as a bug
fix/cleanup.
> It compiles. That's all I'm going to say about my extensive testing.
> Which is also why I haven't added my sign-off to it.
I did quite a bit of load and stress testing on the series back when
I first posted it, so the dcache changes don't have any problems I
know of.
> Comments?
Looks OK to me.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-01-09 20:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 10:58 [RFC PATCH] shrink_dcache_parent() deadlock Miklos Szeredi
2012-01-09 16:43 ` Linus Torvalds
2012-01-09 17:05 ` Miklos Szeredi
2012-01-09 17:05 ` Miklos Szeredi
2012-01-09 17:16 ` Greg KH
2012-01-09 17:16 ` Greg KH
2012-01-09 17:16 ` Christoph Hellwig
2012-01-09 17:30 ` Al Viro
2012-01-09 18:30 ` Linus Torvalds
2012-01-09 18:46 ` Linus Torvalds
2012-01-09 19:04 ` Christoph Hellwig
2012-01-09 19:18 ` Linus Torvalds
2012-01-09 20:59 ` Dave Chinner [this message]
2012-01-09 21:21 ` Linus Torvalds
2012-01-10 1:34 ` Al Viro
2012-01-10 2:02 ` Linus Torvalds
2012-01-10 10:05 ` Miklos Szeredi
2012-01-10 16:00 ` Linus Torvalds
2012-01-10 16:15 ` Al Viro
2012-01-10 16:22 ` Miklos Szeredi
2012-01-10 16:22 ` Miklos Szeredi
2012-01-10 16:33 ` Linus Torvalds
2012-01-10 16:50 ` Miklos Szeredi
2012-01-10 18:04 ` Al Viro
2012-01-10 21:52 ` Dave Chinner
2012-01-10 21:52 ` Dave Chinner
2012-01-09 21:26 ` Al Viro
2012-01-09 17:27 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109205907.GE4198@dastard \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.