From: "Michael Büsch" <m@bues.ch>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Joerg Roedel <joerg.roedel@amd.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: Incorrect uses of get_driver()/put_driver()
Date: Tue, 10 Jan 2012 00:05:19 +0100 [thread overview]
Message-ID: <20120110000519.3d17e64e@milhouse> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1201091520360.1541-100000@iolanthe.rowland.org>
On Mon, 9 Jan 2012 17:44:24 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:
> On Mon, 9 Jan 2012, Michael Büsch wrote:
>
> > On Mon, 9 Jan 2012 14:48:15 -0500 (EST)
> > Alan Stern <stern@rowland.harvard.edu> wrote:
> >
> > > Maybe you want to call device_lock(&sdev->dev) here? It will prevent
> > > the driver from being unbound (and therefore from being unloaded), and
> > > it's likely that sdrv's remove and probe routines expect to be called
> > > with this lock held, because that's what the device core does. The
> > > drawback is that holding the lock prevents other things from happening
> > > as well, like unregistering sdev.
> > >
> > > Alternatively, we can simply remove ssb_driver_get/put.
> >
> > I think in practice it doesn't matter. This function is only
> > used in the rare case where the EEPROM on the board is written.
>
> Okay, then we can just remove those calls and not worry about it for
> now, right?
This would be acceptable.
--
Greetings, Michael.
next prev parent reply other threads:[~2012-01-09 23:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 16:31 Problems with get_driver() and driver_attach() (and new_id too) Alan Stern
2012-01-05 18:01 ` Dmitry Torokhov
2012-01-05 18:55 ` Alan Stern
2012-01-05 20:05 ` Dmitry Torokhov
2012-01-05 20:48 ` Alan Stern
2012-01-05 23:17 ` Greg KH
2012-01-06 14:42 ` Alan Stern
2012-01-06 15:42 ` Alan Stern
2012-01-06 20:29 ` Alan Stern
2012-01-09 8:48 ` Dmitry Torokhov
2012-01-09 16:37 ` Alan Stern
2012-01-09 16:50 ` Dmitry Torokhov
2012-01-09 17:01 ` Alan Stern
2012-01-09 17:05 ` Dmitry Torokhov
2012-01-09 17:35 ` Incorrect uses of get_driver()/put_driver() Alan Stern
2012-01-09 17:48 ` Konrad Rzeszutek Wilk
2012-01-09 18:20 ` Dmitry Torokhov
2012-01-09 18:34 ` Konrad Rzeszutek Wilk
2012-01-09 18:49 ` Dmitry Torokhov
2012-01-09 19:36 ` Alan Stern
2012-01-09 18:03 ` Michael Büsch
2012-01-09 18:14 ` Dmitry Torokhov
2012-01-09 19:48 ` Alan Stern
2012-01-09 20:07 ` Michael Büsch
2012-01-09 22:44 ` Alan Stern
2012-01-09 23:05 ` Michael Büsch [this message]
2012-01-09 18:04 ` Joerg Roedel
2012-01-10 9:05 ` Martin Schwidefsky
2012-01-10 9:20 ` Dmitry Torokhov
2012-01-10 10:03 ` Martin Schwidefsky
2012-01-10 10:18 ` Sebastian Ott
2012-01-10 10:21 ` Sebastian Ott
2012-01-10 20:32 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110000519.3d17e64e@milhouse \
--to=m@bues.ch \
--cc=dmitry.torokhov@gmail.com \
--cc=joerg.roedel@amd.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.