From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dmaengine: shdma: modify the DMAC Address Error registration
Date: Tue, 10 Jan 2012 06:01:02 +0000 [thread overview]
Message-ID: <20120110060102.GA5561@linux-sh.org> (raw)
In-Reply-To: <4F0BCA90.3050508@renesas.com>
On Tue, Jan 10, 2012 at 02:56:33PM +0900, Shimoda, Yoshihiro wrote:
> 2012/01/10 14:33, Paul Mundt wrote:
> > On Tue, Jan 10, 2012 at 02:20:16PM +0900, Shimoda, Yoshihiro wrote:
> >> + if (chanirq_res = errirq_res ||
> >> + (errirq_res->flags & IORESOURCE_BITS) =
> >> + IORESOURCE_IRQ_SHAREABLE)
> >> + irqflags = IRQF_SHARED;
> >> +
> > While not your fault, it seems that there are a few of these cases in
> > which the irqflags are clobbered rather than added to. Is there some
> > particular reason why we aren't doing |= IRQF_SHARED on top of the
> > default IRQF_DISABLED case?
> >
>
> I guess that old kernel (before the commit of 6932bf37 "genirq: Remove IRQF_DISABLED from
> core code") output some warning in request_irq() when irqflags is set to
> "IRQF_DISABLED | IRQF_SHARED".
>
> By the way, according to the "feature-removal-schedule.txt", the IRQF_DISABLED will remove.
> So, we can remove the IRQF_DISABLED in the shdma driver, I think.
>
Yes, it's deprecated now, so there's no need to keep it around. The
non-shared case can just be 0.
next prev parent reply other threads:[~2012-01-10 6:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 5:20 [PATCH v2 1/3] dmaengine: shdma: modify the DMAC Address Error Shimoda, Yoshihiro
2012-01-10 5:33 ` [PATCH v2 1/3] dmaengine: shdma: modify the DMAC Address Error registration Paul Mundt
2012-01-10 5:56 ` [PATCH v2 1/3] dmaengine: shdma: modify the DMAC Address Error Shimoda, Yoshihiro
2012-01-10 6:01 ` Paul Mundt [this message]
2012-01-10 6:19 ` Shimoda, Yoshihiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110060102.GA5561@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.