From: Mel Gorman <mgorman@suse.de>
To: Huang Shijie <b32955@freescale.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, shijie8@gmail.com
Subject: Re: [PATCH] mm/compaction : do optimazition when the migration scanner gets no page
Date: Tue, 10 Jan 2012 09:25:43 +0000 [thread overview]
Message-ID: <20120110092543.GA4118@suse.de> (raw)
In-Reply-To: <1325825861-3702-1-git-send-email-b32955@freescale.com>
On Fri, Jan 06, 2012 at 12:57:41PM +0800, Huang Shijie wrote:
> In the real tests, there are maybe many times the cc->nr_migratepages is zero,
> but isolate_migratepages() returns ISOLATE_SUCCESS.
Odd choice of language. Are there or are there not many times that
cc->nr_migratepages is zero? It does not affect the patch but it is
a slightly confusing changelog.
> In order to get better performance, we should check the number of the
> really isolated pages. And do the optimazition for this case.
>
It's not critical for this patch but in the future it is preferred if
the performance impact can be quantified if that is your justification
for merging. I would expect the performance impact of this patch to
be marginal.
> Also fix the confused comments(from Mel Gorman).
>
> Tested this patch in MX6Q board.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-01-10 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 4:57 [PATCH] mm/compaction : do optimazition when the migration scanner gets no page Huang Shijie
2012-01-10 9:25 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110092543.GA4118@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=b32955@freescale.com \
--cc=linux-mm@kvack.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.