From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49968)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1RkdpB-0002xl-UI
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 10:41:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Rkdp6-0006Vr-8U
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 10:41:21 -0500
Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:49998)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Rkdp6-0006Vg-1U
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 10:41:16 -0500
Received: by lagy4 with SMTP id y4so2140981lag.4
	for <qemu-devel@nongnu.org>; Tue, 10 Jan 2012 07:41:14 -0800 (PST)
Date: Tue, 10 Jan 2012 16:41:12 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20120110154112.GF7565@edde.se.axis.com>
References: <1326191247-14880-1-git-send-email-edgar.iglesias@gmail.com>
	<CAFEAcA86J=P1FUb7AmSNarsD7wWbOzXXxP-5owLo1SFz7xmSeg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAFEAcA86J=P1FUb7AmSNarsD7wWbOzXXxP-5owLo1SFz7xmSeg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] microblaze: Add support for the clz insn
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

On Tue, Jan 10, 2012 at 03:37:51PM +0000, Peter Maydell wrote:
> On 10 January 2012 10:27, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> > +uint32_t helper_clz(uint32_t t0)
> > +{
> > +    if (t0 == 0) {
> > +        return 32;
> > +    }
> > +    if (t0 == ~0) {
> > +        return 0;
> > +    }
> > +    return clz32(t0);
> > +}
> 
> I think clz32() handles both the 0 and 0xffffffff cases correctly,
> so they don't need special-casing.

That seems to be the case, I'll fix that, thanks.

Cheers