From: git@git.openembedded.org
To: bitbake-devel@lists.openembedded.org
Subject: Paul Eggleton : bitbake-layers: close files in apply_append()
Date: Tue, 10 Jan 2012 17:49:03 +0000 (UTC) [thread overview]
Message-ID: <20120110174903.AB19510333@opal> (raw)
Module: bitbake.git
Branch: master
Commit: 470a160813ce6cf04f83258d46ded5c2ab8bc520
URL: http://git.openembedded.org/?p=bitbake.git&a=commit;h=470a160813ce6cf04f83258d46ded5c2ab8bc520
Author: Paul Eggleton <paul.eggleton@linux.intel.com>
Date: Sun Jan 8 12:06:51 2012 +0000
bitbake-layers: close files in apply_append()
It's recommended practice to close files when finished with them and the
code in this function was not doing this.
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
bin/bitbake-layers | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/bin/bitbake-layers b/bin/bitbake-layers
index b4c4127..b4cfd55 100755
--- a/bin/bitbake-layers
+++ b/bin/bitbake-layers
@@ -307,6 +307,8 @@ build results (as the layer priority order has effectively changed).
recipefile.write('\n')
recipefile.write('##### bbappended from %s #####\n' % self.get_append_layer(appendname))
recipefile.writelines(appendfile.readlines())
+ recipefile.close()
+ appendfile.close()
def do_show_appends(self, args):
"""list bbappend files and recipe files they apply to
next reply other threads:[~2012-01-10 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 17:49 git [this message]
2012-01-10 17:41 ` Paul Eggleton : bitbake-layers: close files in apply_append() Chris Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110174903.AB19510333@opal \
--to=git@git.openembedded.org \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.