From: Johan Hedberg <johan.hedberg@gmail.com>
To: Sunil Kumar Behera <sunil.behera@samsung.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH obexd] PBAP: Fix possible invalid memory access
Date: Wed, 11 Jan 2012 16:56:26 +0200 [thread overview]
Message-ID: <20120111145626.GA32565@x220> (raw)
In-Reply-To: <1326179605-3380-1-git-send-email-sunil.behera@samsung.com>
Hi Sunil,
On Tue, Jan 10, 2012, Sunil Kumar Behera wrote:
> Issue: As reported by static code analyzer (Coverity), if
> buffer is NULL and aparams is not NULL, then buffer gets
> dereferenced in string_read function.
> Fix: Application parameter is allocated only if maxlistcount
> is zero during phonebooksize request and buffer is allocated
> in case of pull phonebook request, hence modify logic to avoid
> application parameter check, as it is tightly coupled with
> maxlistcount.
> ---
> plugins/pbap.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
Applied. Thanks.
Johan
prev parent reply other threads:[~2012-01-11 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 7:13 [PATCH obexd] PBAP: Fix possible invalid memory access Sunil Kumar Behera
2012-01-11 14:56 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111145626.GA32565@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sunil.behera@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.