From: Tejun Heo <tj@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: axboe@kernel.dk, mingo@redhat.com, fweisbec@gmail.com,
teravest@google.com, slavapestov@google.com, ctalbott@google.com,
dhsharp@google.com, linux-kernel@vger.kernel.org,
winget@google.com, namhyung@gmail.com
Subject: Re: [PATCH 6/9] block: add block_touch_buffer tracepoint
Date: Wed, 11 Jan 2012 09:58:20 -0800 [thread overview]
Message-ID: <20120111175820.GI26832@google.com> (raw)
In-Reply-To: <1326303721.7642.59.camel@gandalf.stny.rr.com>
On Wed, Jan 11, 2012 at 12:42:01PM -0500, Steven Rostedt wrote:
> On Tue, 2012-01-10 at 10:28 -0800, Tejun Heo wrote:
> >
> > #define CREATE_TRACE_POINTS
> > #include <trace/events/block.h>
> > diff --git a/include/linux/buffer_head.h b/include/linux/buffer_head.h
> > index 458f497..245caed 100644
> > --- a/include/linux/buffer_head.h
> > +++ b/include/linux/buffer_head.h
> > @@ -13,6 +13,7 @@
> > #include <linux/pagemap.h>
> > #include <linux/wait.h>
> > #include <linux/atomic.h>
> > +#include <trace/events/block.h>
>
> trace/events/x.h in a header can cause issue if this header is ever
> included in another trace/events/x.h header. I think I'll need to write
> a patch that allows this, but it wont be pretty.
Hmmm... I see. I'll make touch_buffer() a function.
Thanks.
--
tejun
next prev parent reply other threads:[~2012-01-11 17:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 18:28 [RFC PATCHSET take#2] ioblame: IO tracer with origin tracking Tejun Heo
2012-01-10 18:28 ` [PATCH 1/9] block: abstract disk iteration into disk_iter Tejun Heo
2012-01-10 18:28 ` [PATCH 2/9] block: block_bio_complete tracepoint was missing Tejun Heo
2012-01-11 17:25 ` Steven Rostedt
2012-01-11 17:30 ` Tejun Heo
2012-01-12 0:24 ` Namhyung Kim
2012-01-10 18:28 ` [PATCH 3/9] block: add @req to bio_{front|back}_merge tracepoints Tejun Heo
2012-01-10 18:28 ` [PATCH 4/9] writeback: move struct wb_writeback_work to writeback.h Tejun Heo
2012-01-10 18:28 ` [PATCH 5/9] writeback: add more tracepoints Tejun Heo
2012-01-10 18:28 ` [PATCH 6/9] block: add block_touch_buffer tracepoint Tejun Heo
2012-01-11 17:42 ` Steven Rostedt
2012-01-11 17:58 ` Tejun Heo [this message]
2012-01-10 18:28 ` [PATCH 7/9] vfs: add fcheck tracepoint Tejun Heo
2012-01-10 18:28 ` [PATCH 8/9] stacktrace: implement save_stack_trace_quick() Tejun Heo
2012-01-11 16:26 ` Frederic Weisbecker
2012-01-11 16:38 ` Tejun Heo
2012-01-11 17:37 ` Tejun Heo
2012-01-17 2:22 ` Frederic Weisbecker
2012-01-10 18:28 ` [PATCH 9/9] block, trace: implement ioblame - IO tracer with origin tracking Tejun Heo
2012-01-11 0:25 ` Chanho Park
2012-01-11 1:04 ` Tejun Heo
2012-01-11 1:32 ` [PATCH RESEND " Tejun Heo
2012-01-11 6:15 ` Namhyung Kim
2012-01-11 17:06 ` Tejun Heo
2012-01-12 1:05 ` Namhyung Kim
2012-01-12 1:14 ` Tejun Heo
2012-01-12 1:35 ` Namhyung Kim
2012-01-12 1:37 ` Tejun Heo
2012-01-12 1:40 ` Namhyung Kim
2012-01-12 1:41 ` Namhyung Kim
2012-01-12 1:44 ` Tejun Heo
2012-01-12 2:19 ` Namhyung Kim
2012-01-12 2:24 ` Tejun Heo
2012-01-11 18:08 ` Tejun Heo
2012-01-11 14:40 ` [RFC PATCHSET take#2] ioblame: " Frederic Weisbecker
2012-01-11 17:02 ` Tejun Heo
2012-01-11 22:45 ` David Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111175820.GI26832@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=ctalbott@google.com \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=rostedt@goodmis.org \
--cc=slavapestov@google.com \
--cc=teravest@google.com \
--cc=winget@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.