From: Kees Cook <keescook@chromium.org>
To: Xiaotian Feng <xtfeng@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Xiaotian Feng <dannyfeng@tencent.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Vasiliy Kulikov <segoon@openwall.com>,
Stephen Wilson <wilsons@start.ca>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] proc: fix null pointer deref in proc_pid_permission()
Date: Wed, 11 Jan 2012 12:43:30 -0800 [thread overview]
Message-ID: <20120111204330.GT2618@outflux.net> (raw)
In-Reply-To: <1326307625-11561-1-git-send-email-xtfeng@gmail.com>
Hi,
On Wed, Jan 11, 2012 at 01:47:05PM -0500, Xiaotian Feng wrote:
> get_proc_task() can fail to search the task and return NULL, put_task_struct()
> will then bomb the kernel with following oops:
>
> [ 1870.574045] BUG: unable to handle kernel NULL pointer dereference at 0000000000000010
> [ 1870.574065] IP: [<ffffffff81217d34>] proc_pid_permission+0x64/0xe0
> [ 1870.574088] PGD 112075067 PUD 112814067 PMD 0
> [ 1870.574106] Oops: 0002 [#1] PREEMPT SMP
>
> This is a regression introduced by commit 0499680a, kernel should
> return -ESRCH if get_proc_task() failed.
Nice catch!
However since this error is returned to userspace, shouldn't this be
-ENOENT instead?
-Kees
--
Kees Cook
ChromeOS Security
next prev parent reply other threads:[~2012-01-11 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 18:47 [PATCH] proc: fix null pointer deref in proc_pid_permission() Xiaotian Feng
2012-01-11 20:43 ` Kees Cook [this message]
2012-01-11 21:58 ` Andrew Morton
2012-01-11 22:41 ` Kees Cook
2012-01-12 2:45 ` Xiaotian Feng
2012-01-12 3:05 ` Andrew Morton
2012-01-11 21:49 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120111204330.GT2618@outflux.net \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=dannyfeng@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=segoon@openwall.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wilsons@start.ca \
--cc=xtfeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.