From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
Cc: "Hefty,
Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Atchley, Scott" <atchleyes-1Heg1YXhbW8@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Send with immediate data completion
Date: Wed, 11 Jan 2012 17:51:03 -0700 [thread overview]
Message-ID: <20120112005103.GC31021@obsidianresearch.com> (raw)
In-Reply-To: <CAL1RGDVDR_yNmGyCpFKpH39PF5NG90qo7bBDV+DbGmh7FySiZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Jan 11, 2012 at 03:35:58PM -0800, Roland Dreier wrote:
> On Wed, Jan 11, 2012 at 2:22 PM, Hefty, Sean <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> > The intent is for immediate data only to be provided on receive
> > work completions. ?The IBTA will clarify the spec on this. ?I'll
> > submit patches that remove setting the wc flag, which may help
> > avoid this confusion some.
>
> The unfortunate thing is that we never defined enum values like
>
> IBV_WC_RDMA_WRITE_WITH_IMM
>
> to go along with
>
> IBV_WR_RDMA_WRITE_WITH_IMM
>
> If there was a good reason for that, I've long since forgotten it.
Do you think there is a need to have a WC discern if there was an
attached immediate data? There is no resource attached to the
immediate data that needs special handling.
That is about the only argument I can see for continuing to set
the IBV_WC_WITH_IMM flag on the WC.
All I think is really needed here is a firm note someplace that
imm_data is only valid if IBV_WC_RECV is set, while IBV_WC_WITH_IMM
is set based on the opcode.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-12 0:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 21:59 Send with immediate data completion Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373256758E5-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-11 22:22 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823732567591B-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-11 23:35 ` Roland Dreier
[not found] ` <CAL1RGDVDR_yNmGyCpFKpH39PF5NG90qo7bBDV+DbGmh7FySiZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12 0:51 ` Jason Gunthorpe [this message]
2012-01-12 15:57 ` Atchley, Scott
-- strict thread matches above, loose matches on Subject: below --
2012-01-03 16:08 Atchley, Scott
[not found] ` <11EC89F0-2BFD-4727-BC45-AD30E0F10348-1Heg1YXhbW8@public.gmane.org>
2012-01-03 16:55 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A823732566A099-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-03 17:35 ` Atchley, Scott
[not found] ` <9A17BA94-61E0-4176-81CF-98BE023320AF-1Heg1YXhbW8@public.gmane.org>
2012-01-11 14:50 ` Atchley, Scott
[not found] ` <7B006904-1749-4562-B2FD-1A0E5212A449-1Heg1YXhbW8@public.gmane.org>
2012-01-11 16:15 ` Hefty, Sean
2012-01-03 17:38 ` Atchley, Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112005103.GC31021@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=atchleyes-1Heg1YXhbW8@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.