All of lore.kernel.org
 help / color / mirror / Atom feed
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] versatile: don't generate a duplicate IRQ domain
Date: Thu, 12 Jan 2012 23:30:50 +0000	[thread overview]
Message-ID: <20120112233050.GC14007@page> (raw)
In-Reply-To: <20120112232827.GP1068@n2100.arm.linux.org.uk>

On Thu, Jan 12, 2012 at 11:28:27PM +0000, Russell King - ARM Linux wrote:
> On Thu, Jan 12, 2012 at 11:26:11PM +0000, Jamie Iles wrote:
> > No, because:
> > 
> > 	vic_init()
> > 	  __vic_init() -> with NULL np pointer
> > 	    vic_register()
> > 	
> > So we won't have the device_node for the VIC.  I think I really need to 
> > convert the versatile stuff over to the full of_irq_init() method of 
> > probing, which isn't as bad as I thought as everything is populated from 
> > the DT there but it looked like it could be registered statically too 
> > from versatile_init().  I'll try and get everything going from the DT 
> > now.
> 
> Won't this make Versatile a DT-only platform?

No, crap explanation by me there.  I'll add a versatile_dt_irq_init() 
that creates the controllers from the DT, for the non DT case everything 
will be as before using the static assignments and static irq_descs.  
I'll make sure to test using both booting methods.

Jamie

      reply	other threads:[~2012-01-12 23:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 16:39 [PATCH] versatile: don't generate a duplicate IRQ domain Jamie Iles
2012-01-12 20:37 ` Russell King - ARM Linux
2012-01-12 21:58   ` Jamie Iles
2012-01-12 22:14     ` Russell King - ARM Linux
2012-01-12 23:07       ` Grant Likely
2012-01-12 23:18         ` Russell King - ARM Linux
2012-01-12 23:26           ` Jamie Iles
2012-01-12 23:28             ` Russell King - ARM Linux
2012-01-12 23:30               ` Jamie Iles [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120112233050.GC14007@page \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.