From: Minchan Kim <minchan@kernel.org>
To: Huang Shijie <b32955@freescale.com>
Cc: Mel Gorman <mgorman@suse.de>,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/compaction : do optimazition when the migration scanner gets no page
Date: Fri, 13 Jan 2012 12:12:21 +0900 [thread overview]
Message-ID: <20120113031221.GA6473@barrios-desktop> (raw)
In-Reply-To: <4F0F987E.1080001@freescale.com>
On Fri, Jan 13, 2012 at 10:35:42AM +0800, Huang Shijie wrote:
> Hi,
> >I think simple patch is returning "return cc->nr_migratepages ? ISOLATE_SUCCESS : ISOLATE_NONE;"
> >It's very clear and readable, I think.
> >In this patch, what's the problem you think?
> >
> sorry for the wrong thread, please read the following thread:
> http://marc.info/?l=linux-mm&m=132532266130861&w=2
Huang, Thanks for notice that thread.
I read and if I understand correctly, the point is that Mel want to see tracepoint
"trace_mm_compaction_migratepages" and account "count_vm_event(COMPACTBLOCKS);"
My patch does accounting COMPACTBLOCKS so it's not a problem.
The problem is my patch doesn't emit trace of "trace_mm_compaction_migratepages".
But doesn't it matter? When we doesn't isolate any page at all, both argument in
trace_mm_compaction_migratepages are always zero. Is it meaningful tracepoint?
Do we really want it?
>
> Best Regards
> Huang Shijie
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-13 3:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 5:47 [PATCH v2] mm/compaction : do optimazition when the migration scanner gets no page Huang Shijie
2012-01-12 8:03 ` Minchan Kim
2012-01-12 8:26 ` Huang Shijie
2012-01-12 8:32 ` Minchan Kim
2012-01-12 8:38 ` Huang Shijie
2012-01-12 11:48 ` Mel Gorman
2012-01-13 0:50 ` Minchan Kim
2012-01-13 2:35 ` Huang Shijie
2012-01-13 3:12 ` Minchan Kim [this message]
2012-01-13 3:31 ` Huang Shijie
2012-01-13 3:50 ` Minchan Kim
2012-01-13 10:48 ` Mel Gorman
2012-01-13 10:34 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113031221.GA6473@barrios-desktop \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=b32955@freescale.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.