From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Lu Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() Date: Fri, 13 Jan 2012 14:32:27 +0800 Message-ID: <20120113063226.GC2701@ladygaga> References: <1323399230-29118-1-git-send-email-r66093@freescale.com> <8A2FC72B45BB5A4C9F801431E06AE48F116692B2@039-SN1MPN1-005.039d.mgd.msft.net> <20120113032628.GA7564@ladygaga> <8A2FC72B45BB5A4C9F801431E06AE48F1166942B@039-SN1MPN1-005.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from db3ehsobe006.messaging.microsoft.com ([213.199.154.144]:40768 "EHLO DB3EHSOBE006.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088Ab2AMGcm (ORCPT ); Fri, 13 Jan 2012 01:32:42 -0500 Content-Disposition: inline In-Reply-To: <8A2FC72B45BB5A4C9F801431E06AE48F1166942B@039-SN1MPN1-005.039d.mgd.msft.net> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Huang Changming-R66093 Cc: "linux-mmc@vger.kernel.org" , Chris Ball Hi, On Fri, Jan 13, 2012 at 03:39:53AM +0000, Huang Changming-R66093 wrote: > > > > -----Original Message----- > > From: Aaron Lu [mailto:aaron.lu@amd.com] > > Sent: Friday, January 13, 2012 11:27 AM > > To: Huang Changming-R66093 > > Cc: linux-mmc@vger.kernel.org; Chris Ball > > Subject: Re: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() > > > > Hi, > > > > On Fri, Jan 13, 2012 at 02:24:46AM +0000, Huang Changming-R66093 wrote: > > > Hi, Chris, > > > Could you have any comment about this patch? > > > Can it go into 3.3 or 3.4? > > > > > > > -----Original Message----- > > > > From: Huang Changming-R66093 > > > > Sent: Friday, December 09, 2011 10:54 AM > > > > To: linux-mmc@vger.kernel.org > > > > Cc: Huang Changming-R66093; Chris Ball > > > > Subject: [PATCH 1/4 v3] MMC/core: Add f_min to mmc_power_on() > > > > > > > > From: Jerry Huang > > > > > > > > When f_init is zero, the SDHC can't work correctly. So f_min will > > > > replace f_init, when f_init is zero. > > > > What about setting f_init before your call to mmc_power_up? > f_init is initialized only by mmc_rescan_try_freq, and mmc_power_up will use it. > But mmc_power_up will called not only by mmc_rescan_try_freq, but also by other functions. > You will see it in my previous email about it. > Yes, I know there are other callers for mmc_power_up. Either you set host->f_init in mmc_power_up, or you set it before you call mmc_power_up. I prefer the latter one but I'm not sure which one should be used. Maybe Chris can comment on this.