All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (lm63) LM64 has a dedicated pin for tachometer
Date: Fri, 13 Jan 2012 12:14:37 +0000	[thread overview]
Message-ID: <20120113121437.GA22406@ericsson.com> (raw)
In-Reply-To: <20120113101321.366a6f35@endymion.delvare>

On Fri, Jan 13, 2012 at 04:13:21AM -0500, Jean Delvare wrote:
> On the LM64, the tachometer function has a dedicated pin and fan speed
> monitoring is always enabled.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
>  Documentation/hwmon/lm63 |    4 +++-
>  drivers/hwmon/lm63.c     |    3 ++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> --- linux-3.3-rc0.orig/Documentation/hwmon/lm63	2012-01-13 09:09:25.000000000 +0100
> +++ linux-3.3-rc0/Documentation/hwmon/lm63	2012-01-13 09:54:38.000000000 +0100
> @@ -54,7 +54,9 @@ value for measuring the speed of the fan
>  Note that the pin used for fan monitoring is shared with an alert out
>  function. Depending on how the board designer wanted to use the chip, fan
>  speed monitoring will or will not be possible. The proper chip configuration
> -is left to the BIOS, and the driver will blindly trust it.
> +is left to the BIOS, and the driver will blindly trust it. Only the original
> +LM63 suffers from this limitation, the LM64 and LM96163 have separate pins
> +for fan monitoring and alert out.
>  
>  A PWM output can be used to control the speed of the fan. The LM63 has two
>  PWM modes: manual and automatic. Automatic mode is not fully implemented yet
> --- linux-3.3-rc0.orig/drivers/hwmon/lm63.c	2012-01-13 09:33:23.000000000 +0100
> +++ linux-3.3-rc0/drivers/hwmon/lm63.c	2012-01-13 09:53:19.000000000 +0100
> @@ -745,7 +745,8 @@ static int lm63_probe(struct i2c_client
>  	err = sysfs_create_group(&new_client->dev.kobj, &lm63_group);
>  	if (err)
>  		goto exit_free;
> -	if (data->config & 0x04) { /* tachometer enabled */
> +	if (data->kind = lm64 ||	/* tachometer has dedicated pin */
> +	    (data->config & 0x04)) {	/* tachometer enabled */
>  		err = sysfs_create_group(&new_client->dev.kobj,
>  					 &lm63_group_fan1);
>  		if (err)
> 
Just realized: In lm63_update_device(), the code checks for data->config & 0x04 again
and never reads the fan registers if it is 0. Since the bit is reserved on LM64, fan status
will never be read for it.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2012-01-13 12:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13  9:13 [lm-sensors] [PATCH] hwmon: (lm63) LM64 has a dedicated pin for tachometer Jean Delvare
2012-01-13 11:55 ` Guenter Roeck
2012-01-13 12:14 ` Guenter Roeck [this message]
2012-01-13 12:38 ` Jean Delvare
2012-01-13 12:40 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120113121437.GA22406@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.